Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11636043: Added ellipses when the title of notifications is too long. (Closed)

Created:
8 years ago by dharcourt
Modified:
7 years, 11 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, miket_OOO
Visibility:
Public.

Description

Added ellipses when the title of notifications is too long. Notification mock-ups show ellipses at the end of text when there is not enough room for that text. Previously title text in multi-item notifications had a trailing fade instead of trailing ellipses. This changes that to ellipses. BUG=161101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175122

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/message_center/notification_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dharcourt
One line change...
8 years ago (2012-12-20 05:45:28 UTC) #1
Jun Mukai
lgtm you can mix this to your another CL though :)
8 years ago (2012-12-20 18:10:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/11636043/4001
7 years, 11 months ago (2013-01-04 06:22:15 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 08:14:57 UTC) #4
Message was sent while issue was closed.
Change committed as 175122

Powered by Google App Engine
This is Rietveld 408576698