Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3804)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_delegate.h

Issue 11636040: AutofillPopupController clarifications + simplifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ilya review Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_delegate.h
diff --git a/chrome/browser/autofill/autofill_popup_delegate.h b/chrome/browser/ui/autofill/autofill_popup_delegate.h
similarity index 50%
rename from chrome/browser/autofill/autofill_popup_delegate.h
rename to chrome/browser/ui/autofill/autofill_popup_delegate.h
index 6411766e130faa5e0fb40ab917e6ed75d225ef6c..20348ac8c73273768f1bfc250ccd3a1fdfe0a21f 100644
--- a/chrome/browser/autofill/autofill_popup_delegate.h
+++ b/chrome/browser/ui/autofill/autofill_popup_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
-#define CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
+#ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
+#define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
#include "base/string16.h"
@@ -11,22 +11,21 @@
// of events by the controller.
class AutofillPopupDelegate {
public:
- // Called when the autofill suggestion indicated by |unique_id| has been
+ // Called when the autofill suggestion indicated by |identifier| has been
// temporarily selected (e.g., hovered).
- virtual void SelectAutofillSuggestionAtIndex(int unique_id) = 0;
+ virtual void DidSelectSuggestion(int identifier) = 0;
- // Inform the delegate that an Autofill suggestion has been chosen. Returns
- // true if the suggestion was selected.
- virtual bool DidAcceptAutofillSuggestion(const string16& value,
- int unique_id,
- unsigned index) = 0;
+ // Inform the delegate that a row in the popup has been chosen.
+ // TODO(estade): this should only pass |identifier|.
+ virtual void DidAcceptSuggestion(const string16& value, int identifier) = 0;
+
+ // Delete the given Autofill profile or credit credit.
+ virtual void RemoveSuggestion(int identifier) = 0;
// Remove the given Autocomplete entry from the DB.
+ // TODO(estade): this should pass |identifier|.
virtual void RemoveAutocompleteEntry(const string16& value) = 0;
- // Remove the given Autofill profile or credit credit.
- virtual void RemoveAutofillProfileOrCreditCard(int unique_id) = 0;
-
// Informs the delegate that the Autofill previewed form should be cleared.
virtual void ClearPreviewedForm() = 0;
@@ -34,4 +33,4 @@ class AutofillPopupDelegate {
virtual void ControllerDestroyed() = 0;
};
-#endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
+#endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698