AutofillPopupController clarifications + simplifications.

chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_GTK_AUTOFILL_AUTOFILL_POPUP_VIEW_GTK_H_
 #define CHROME_BROWSER_UI_GTK_AUTOFILL_AUTOFILL_POPUP_VIEW_GTK_H_
 
 #include <pango/pango.h>
 #include <vector>
 
@@ skipping 40 matching lines @@
   CHROMEGTK_CALLBACK_1(AutofillPopupViewGtk, gboolean, HandleButtonRelease,
                        GdkEventButton*);
   CHROMEGTK_CALLBACK_1(AutofillPopupViewGtk, gboolean, HandleExpose,
                        GdkEventExpose*);
   CHROMEGTK_CALLBACK_1(AutofillPopupViewGtk, gboolean, HandleLeave,
                        GdkEventCrossing*)
   CHROMEGTK_CALLBACK_1(AutofillPopupViewGtk, gboolean, HandleMotion,
                        GdkEventMotion*);
 
   // Set up the pango layout to display the autofill results.
-  void SetupLayout(const gfx::Rect& window_rect);
+  void SetupLayout();

[Ilya Sherman, 2012/12/20 04:34:52]

nit: SetUpLayout()

[Evan Stade, 2012/12/20 20:01:25]

Done.

 
   // Set up the pango layout to print the given text and have it's width match
   // the text's (this gives us better control when placing the text box).
   void SetLayoutText(const string16& text,
                      const gfx::Font& font,
                      const GdkColor text_color);
 
   // Draw the separator as the given |separator_rect|.
   void DrawSeparator(cairo_t* cairo_context, const gfx::Rect& separator_rect);
 
   // Draw the given autofill entry in |entry_rect|.
   void DrawAutofillEntry(cairo_t* cairo_context,
                          size_t index,
                          const gfx::Rect& entry_rect);
 
   // Set the initial bounds of the popup to show, including the placement
   // of it.
   void SetInitialBounds();
 
   AutofillPopupController* controller_;  // Weak reference.
 
   GtkWidget* window_;  // Strong reference.
   PangoLayout* layout_;  // Strong reference.
 
   DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewGtk);
 };
 
 #endif  // CHROME_BROWSER_UI_GTK_AUTOFILL_AUTOFILL_POPUP_VIEW_GTK_H_