AutofillPopupController clarifications + simplifications.

chrome/browser/ui/autofill/autofill_popup_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_
 
 #include "base/string16.h"
 
 // An interface for interaction with AutofillPopupController. Will be notified
 // of events by the controller.
 class AutofillPopupDelegate {
  public:
   // Called when the autofill suggestion indicated by |unique_id| has been
   // temporarily selected (e.g., hovered).
   virtual void SelectAutofillSuggestion(int unique_id) = 0;
 
   // Inform the delegate that a row in the popup has been chosen.
-  // TODO(estade): does this really need to return a value?
-  virtual bool DidAcceptAutofillSuggestion(const string16& value,
-                                           int unique_id,
-                                           unsigned index) = 0;
+  // TODO(estade): this should only pass |unique_id|.

[Ilya Sherman, 2012/12/20 04:34:52]

All autocomplete items have the same unique id, which is 0.  Ditto for passwords
and datalist elements.

[Evan Stade, 2012/12/20 20:01:25]

doesn't sound very unique then. Those things should probably be give actually
unique identifiers.

[Ilya Sherman, 2012/12/20 21:57:42]

Everything other than Autofill profiles and credit cards is uniquely identified
by its value.  The profiles and credit cards, OTOH, need more.  What we should
really do is to split this into two fields: a required one that specifies the
data type, and an optional (i.e. sometimes NULL) one that specifies which
FormGroup the data comes from.  I think that will be easier to do once the old
UI is fully dead.

[Evan Stade, 2012/12/20 23:03:59]

how would the delegate know which password you're accepting?  

I've removed the TODO.

[Ilya Sherman, 2012/12/20 23:11:55]

A given username on a given site only ever has one password associated with it.

+  virtual void DidAcceptAutofillSuggestion(const string16& value,
+                                           int unique_id) = 0;
 
   // Remove the given Autocomplete entry from the DB.
+  // TODO(estade): this should pass |unique_id|.
   virtual void RemoveAutocompleteEntry(const string16& value) = 0;
 
   // Remove the given Autofill profile or credit credit.
   virtual void RemoveAutofillProfileOrCreditCard(int unique_id) = 0;
 
   // Informs the delegate that the Autofill previewed form should be cleared.
   virtual void ClearPreviewedForm() = 0;
 
   // Called to inform the delegate the controller is experiencing destruction.
   virtual void ControllerDestroyed() = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_POPUP_DELEGATE_H_