Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 11636038: [Android WebView] Add a system property to disable OpenGL state restoration in the GL functor. (Closed)

Created:
8 years ago by Leandro Graciá Gil
Modified:
8 years ago
Reviewers:
joth
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Add a system property to disable OpenGL state restoration in the draw functor. Add support to disable GL state restoration in Android GL functor calls when the webview.chromium_no_gl_restore property is set to "true". BUG=164140 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174221

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -41 lines) Patch
M android_webview/native/aw_contents.cc View 2 chunks +49 lines, -41 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Leandro Graciá Gil
8 years ago (2012-12-20 01:47:22 UTC) #1
joth
lgtm https://codereview.chromium.org/11636038/diff/1/android_webview/native/aw_contents.cc File android_webview/native/aw_contents.cc (right): https://codereview.chromium.org/11636038/diff/1/android_webview/native/aw_contents.cc#newcode348 android_webview/native/aw_contents.cc:348: LOG(WARNING) << "Android GL functor not restoring the ...
8 years ago (2012-12-20 02:52:17 UTC) #2
Leandro Graciá Gil
https://codereview.chromium.org/11636038/diff/1/android_webview/native/aw_contents.cc File android_webview/native/aw_contents.cc (right): https://codereview.chromium.org/11636038/diff/1/android_webview/native/aw_contents.cc#newcode348 android_webview/native/aw_contents.cc:348: LOG(WARNING) << "Android GL functor not restoring the previous ...
8 years ago (2012-12-20 03:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11636038/1
8 years ago (2012-12-20 18:09:44 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-20 20:23:31 UTC) #5
Message was sent while issue was closed.
Change committed as 174221

Powered by Google App Engine
This is Rietveld 408576698