Make VKEY_F14 and VKEY_HELP close keyboard overlay.

Make VKEY_F14 and VKEY_HELP close keyboard overlay.

Also add tests to verify that the shortcuts that open the keyboard overlay close it.

BUG=chrome-os-partner:16067
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174220

[mazda, 2012-12-20 01:46:12]

Could you review this CL?

[Daniel Erat, 2012-12-20 04:55:25]

lgtm

https://codereview.chromium.org/11636037/diff/2001/ash/keyboard_overlay/keybo...
File ash/keyboard_overlay/keyboard_overlay_view.cc (right):

https://codereview.chromium.org/11636037/diff/2001/ash/keyboard_overlay/keybo...
ash/keyboard_overlay/keyboard_overlay_view.cc:89: CHECK(canceling_keys);
nit: canceling_keys->clear() ?

otherwise, document that it just appends to the existing vector.

[mazda, 2012-12-20 08:51:10]

https://codereview.chromium.org/11636037/diff/2001/ash/keyboard_overlay/keybo...
File ash/keyboard_overlay/keyboard_overlay_view.cc (right):

https://codereview.chromium.org/11636037/diff/2001/ash/keyboard_overlay/keybo...
ash/keyboard_overlay/keyboard_overlay_view.cc:89: CHECK(canceling_keys);
On 2012/12/20 04:55:25, Daniel Erat wrote:
> nit: canceling_keys->clear() ?
> 
> otherwise, document that it just appends to the existing vector.

Added clear(). Thanks.

[mazda, 2012-12-20 16:40:05]

+sky
Could you do an OWNERS review for ui/?

[sky, 2012-12-20 17:51:27]

LGTM

[commit-bot: I haz the power, 2012-12-20 17:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/11636037/5002

[commit-bot: I haz the power, 2012-12-20 20:21:15]

Change committed as 174220