Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 11635063: [Spellcheck] Removing the "no more suggestions from Google" line when using the spelling service (Closed)

Created:
8 years ago by rpetterson
Modified:
7 years, 11 months ago
Reviewers:
groby-ooo-7-16, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

[Spellcheck] Removing the "no more suggestions from Google" line when using the spelling service When using the spelling service, we should not show the "no more suggestions from Google" since that should intelligently figure out the correct suggestion. BUG=119483 TEST=run using --use-spelling-service and observe that it shows only the single suggestion. run without that flag and observe that it will still show "no more suggestions from Google" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175178

Patch Set 1 #

Patch Set 2 : cleaning code #

Total comments: 8

Patch Set 3 : responding to comments (browsertest, prebind) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -33 lines) Patch
M chrome/browser/spellchecker/spellcheck_message_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.h View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 1 2 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 2 4 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer_browsertest.cc View 1 2 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
groby -- spellcheck correctness brettw - tab_contents owners approval
8 years ago (2012-12-21 03:47:37 UTC) #1
groby-ooo-7-16
LGTM w/ nits https://codereview.chromium.org/11635063/diff/2001/chrome/browser/spellchecker/spelling_service_client.cc File chrome/browser/spellchecker/spelling_service_client.cc (right): https://codereview.chromium.org/11635063/diff/2001/chrome/browser/spellchecker/spelling_service_client.cc#newcode103 chrome/browser/spellchecker/spelling_service_client.cc:103: type_ = type; Since tag_ and ...
8 years ago (2012-12-21 22:18:13 UTC) #2
rpetterson
brettw -- ping for owners approval when you have a moment https://codereview.chromium.org/11635063/diff/2001/chrome/browser/spellchecker/spelling_service_client.cc File chrome/browser/spellchecker/spelling_service_client.cc (right): ...
7 years, 11 months ago (2013-01-04 00:05:34 UTC) #3
brettw
lgtm rubberstamp
7 years, 11 months ago (2013-01-04 00:07:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/11635063/8001
7 years, 11 months ago (2013-01-04 18:59:42 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 20:13:21 UTC) #6
Message was sent while issue was closed.
Change committed as 175178

Powered by Google App Engine
This is Rietveld 408576698