Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 11635039: [Autofill] Update unit tests to use country codes when setting raw address info. (Closed)

Created:
8 years ago by Ilya Sherman
Modified:
7 years, 11 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

[Autofill] Update unit tests to use country codes when setting raw address info. BUG=100845 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M chrome/browser/autofill/address_unittest.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_profile_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
8 years ago (2012-12-20 05:31:10 UTC) #1
Ilya Sherman
David, ping :)
7 years, 11 months ago (2013-01-04 23:26:58 UTC) #2
dhollowa
Gosh, sorry. Missed this somehow. LGTM.
7 years, 11 months ago (2013-01-04 23:38:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11635039/1
7 years, 11 months ago (2013-01-04 23:40:06 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 01:30:30 UTC) #5
Message was sent while issue was closed.
Change committed as 175254

Powered by Google App Engine
This is Rietveld 408576698