Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: content/browser/devtools/devtools_manager_impl.cc

Issue 11633035: DevTools: prepare workers for DevToolsManager::Attach(Detach)ClientHost removal. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Patch for landing Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_agent_host.cc ('k') | content/browser/devtools/worker_devtools_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_manager_impl.cc
diff --git a/content/browser/devtools/devtools_manager_impl.cc b/content/browser/devtools/devtools_manager_impl.cc
index a5a72e4a02c076c2e83d491712a4e2f107316574..c15e5f2b77620c32ace982bed170d7d7f55c352e 100644
--- a/content/browser/devtools/devtools_manager_impl.cc
+++ b/content/browser/devtools/devtools_manager_impl.cc
@@ -241,9 +241,12 @@ void DevToolsManagerImpl::UnbindClientHost(DevToolsAgentHost* agent_host,
FROM_HERE,
base::Bind(&DevToolsNetLogObserver::Detach));
}
+ int process_id = agent_host->GetRenderProcessId();
+
+ // Lazy agent hosts can be deleted from within detach.
+ // Do not access agent_host below this line.
agent_host->Detach();
- int process_id = agent_host->GetRenderProcessId();
if (process_id == -1)
return;
for (AgentToClientHostMap::iterator it = agent_to_client_host_.begin();
« no previous file with comments | « content/browser/devtools/devtools_agent_host.cc ('k') | content/browser/devtools/worker_devtools_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698