content/browser/frame_host/navigation_request.h - Issue 1163303003: PlzNavigate: Create the speculative renderer earlier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.h

Issue 1163303003: PlzNavigate: Create the speculative renderer earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes from nako@'s review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/frame_tree_node.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_request.h

diff --git a/content/browser/frame_host/navigation_request.h b/content/browser/frame_host/navigation_request.h

index ce5c5468b10897cef36843977db4064f5bbe8f89..f15c14d656f57f8283716dafddefc47df3728ffb 100644

--- a/content/browser/frame_host/navigation_request.h

+++ b/content/browser/frame_host/navigation_request.h

@@ -54,7 +54,8 @@ class CONTENT_EXPORT NavigationRequest : public NavigationURLLoaderDelegate {

};

// Helper function to determine if the navigation request to |url| should be

- // sent to the network stack.

+ // sent to the network stack. It will not be sent for data URLs or Javascript

nasko 2015/06/15 22:12:45 nit: JavaScript

carlosk 2015/06/16 10:14:46 Done.

+ // URLs, cases where no network request needs to be made.

static bool ShouldMakeNetworkRequest(const GURL& url);

// Creates a request for a browser-intiated navigation.