PlzNavigate: Create the speculative renderer earlier.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 1663 matching lines @@
       params.user_gesture);
 }
 
 void RenderFrameHostImpl::Stop() {
   Send(new FrameMsg_Stop(routing_id_));
 }
 
 void RenderFrameHostImpl::DispatchBeforeUnload(bool for_navigation) {
   // TODO(creis): Support beforeunload on subframes.  For now just pretend that
   // the handler ran and allowed the navigation to proceed.
-  if (GetParent() || !IsRenderFrameLive()) {
-    // We don't have a live renderer, so just skip running beforeunload.
+  if (!ShouldDispatchBeforeUnload()) {
+    // We don't have a live renderer or are on a subframe, so just skip running

[clamy, 2015/06/09 16:01:30]

If changing the comment, rephrase so that it does not use we.

[carlosk, 2015/06/10 11:53:09]

Done.

+    // beforeunload.
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[clamy, 2015/06/09 16:07:44]

Now that I think about it, we should never end up there for a navigation in
PlzNavigate. Can you add a DCHECK(!base... || !for_navigation) here and remove
the if/else condition.

[carlosk, 2015/06/10 11:53:09]

Done.

         switches::kEnableBrowserSideNavigation)) {
       frame_tree_node_->navigator()->OnBeforeUnloadACK(
           frame_tree_node_, true);
     } else {
       frame_tree_node_->render_manager()->OnBeforeUnloadACK(
           for_navigation, true, base::TimeTicks::Now());
     }
     return;
   }
   TRACE_EVENT_ASYNC_BEGIN0(
@@ skipping 19 matching lines @@
     // Increment the in-flight event count, to ensure that input events won't
     // cancel the timeout timer.
     render_view_host_->increment_in_flight_event_count();
     render_view_host_->StartHangMonitorTimeout(
         TimeDelta::FromMilliseconds(RenderViewHostImpl::kUnloadTimeoutMS));
     send_before_unload_start_time_ = base::TimeTicks::Now();
     Send(new FrameMsg_BeforeUnload(routing_id_));
   }
 }
 
+bool RenderFrameHostImpl::ShouldDispatchBeforeUnload() {

[clamy, 2015/06/09 16:01:30]

I think you may copy the TODO(creis): Support beforeunload on subframes. here.

[carlosk, 2015/06/10 11:53:09]

Done.

+  return !GetParent() && IsRenderFrameLive();
+}
+
 void RenderFrameHostImpl::DisownOpener() {
   Send(new FrameMsg_DisownOpener(GetRoutingID()));
 }
 
 void RenderFrameHostImpl::ExtendSelectionAndDelete(size_t before,
                                                    size_t after) {
   Send(new InputMsg_ExtendSelectionAndDelete(routing_id_, before, after));
 }
 
 void RenderFrameHostImpl::JavaScriptDialogClosed(
@@ skipping 335 matching lines @@
   // We may be returning to an existing NavigationEntry that had been granted
   // file access.  If this is a different process, we will need to grant the
   // access again.  The files listed in the page state are validated when they
   // are received from the renderer to prevent abuse.
   if (request_params.page_state.IsValid()) {
     render_view_host_->GrantFileAccessFromPageState(request_params.page_state);
   }
 }
 
 }  // namespace content