Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 11633020: Re-enable about:flags on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 98b27e0d205e7cdb26d8cabbaa798c363b64c9f5..b4c97e44a914b3075e90395e96a0aeff2a082d1d 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -199,6 +199,8 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
return &NewWebUI<WebDialogUI>;
if (url.spec() == chrome::kChromeUIConstrainedHTMLTestURL)
return &NewWebUI<ConstrainedWebDialogUI>;
+ if (url.host() == chrome::kChromeUIFlagsHost)
+ return &NewWebUI<FlagsUI>;
if (url.host() == chrome::kChromeUIGpuInternalsHost)
return &NewWebUI<GpuInternalsUI>;
if (url.host() == chrome::kChromeUIHistoryFrameHost)
@@ -257,10 +259,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
// Feedback on Android uses the built-in feedback app.
if (url.host() == chrome::kChromeUIFeedbackHost)
return &NewWebUI<FeedbackUI>;
- // chrome://flags is currently unsupported on Android.
- // TODO(satish): Enable after http://crbug.com/143146 is fixed.
- if (url.host() == chrome::kChromeUIFlagsHost)
- return &NewWebUI<FlagsUI>;
// Flash is not available on android.
if (url.host() == chrome::kChromeUIFlashHost)
return &NewWebUI<FlashUI>;
@@ -595,6 +593,9 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host() == chrome::kChromeUICrashesHost)
return CrashesUI::GetFaviconResourceBytes(scale_factor);
+ if (page_url.host() == chrome::kChromeUIFlagsHost)
+ return FlagsUI::GetFaviconResourceBytes(scale_factor);
+
if (page_url.host() == chrome::kChromeUIHistoryHost)
return HistoryUI::GetFaviconResourceBytes(scale_factor);
@@ -607,11 +608,6 @@ base::RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host() == chrome::kChromeUIDownloadsHost)
return DownloadsUI::GetFaviconResourceBytes(scale_factor);
- // chrome://flags is currently unsupported on Android.
- // TODO(satish): Enable after http://crbug.com/143146 is fixed.
- if (page_url.host() == chrome::kChromeUIFlagsHost)
- return FlagsUI::GetFaviconResourceBytes(scale_factor);
-
// Android doesn't use the Options pages.
if (page_url.host() == chrome::kChromeUISettingsFrameHost)
return options::OptionsUI::GetFaviconResourceBytes(scale_factor);

Powered by Google App Engine
This is Rietveld 408576698