Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 11633020: Re-enable about:flags on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nilesh's comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h" 5 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/message_loop_proxy.h" 10 #include "base/message_loop_proxy.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 // after the host name. 192 // after the host name.
193 // All platform builds of Chrome will need to have a cloud printing 193 // All platform builds of Chrome will need to have a cloud printing
194 // dialog as backup. It's just that on Chrome OS, it's the only 194 // dialog as backup. It's just that on Chrome OS, it's the only
195 // print dialog. 195 // print dialog.
196 if (url.host() == chrome::kChromeUICloudPrintResourcesHost) 196 if (url.host() == chrome::kChromeUICloudPrintResourcesHost)
197 return &NewWebUI<ExternalWebDialogUI>; 197 return &NewWebUI<ExternalWebDialogUI>;
198 if (url.host() == chrome::kChromeUICloudPrintSetupHost) 198 if (url.host() == chrome::kChromeUICloudPrintSetupHost)
199 return &NewWebUI<WebDialogUI>; 199 return &NewWebUI<WebDialogUI>;
200 if (url.spec() == chrome::kChromeUIConstrainedHTMLTestURL) 200 if (url.spec() == chrome::kChromeUIConstrainedHTMLTestURL)
201 return &NewWebUI<ConstrainedWebDialogUI>; 201 return &NewWebUI<ConstrainedWebDialogUI>;
202 if (url.host() == chrome::kChromeUIFlagsHost)
203 return &NewWebUI<FlagsUI>;
202 if (url.host() == chrome::kChromeUIGpuInternalsHost) 204 if (url.host() == chrome::kChromeUIGpuInternalsHost)
203 return &NewWebUI<GpuInternalsUI>; 205 return &NewWebUI<GpuInternalsUI>;
204 if (url.host() == chrome::kChromeUIHistoryFrameHost) 206 if (url.host() == chrome::kChromeUIHistoryFrameHost)
205 return &NewWebUI<HistoryUI>; 207 return &NewWebUI<HistoryUI>;
206 if (url.host() == chrome::kChromeUIInstantHost) 208 if (url.host() == chrome::kChromeUIInstantHost)
207 return &NewWebUI<InstantUI>; 209 return &NewWebUI<InstantUI>;
208 if (url.host() == chrome::kChromeUILocalOmniboxPopupHost) 210 if (url.host() == chrome::kChromeUILocalOmniboxPopupHost)
209 return &NewWebUI<LocalOmniboxPopupUI>; 211 return &NewWebUI<LocalOmniboxPopupUI>;
210 if (url.host() == chrome::kChromeUIMediaInternalsHost) 212 if (url.host() == chrome::kChromeUIMediaInternalsHost)
211 return &NewWebUI<MediaInternalsUI>; 213 return &NewWebUI<MediaInternalsUI>;
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 if (url.host() == chrome::kChromeUIDevToolsHost) 254 if (url.host() == chrome::kChromeUIDevToolsHost)
253 return &NewWebUI<DevToolsUI>; 255 return &NewWebUI<DevToolsUI>;
254 // Downloads list on Android uses the built-in download manager. 256 // Downloads list on Android uses the built-in download manager.
255 if (url.host() == chrome::kChromeUIDownloadsHost) 257 if (url.host() == chrome::kChromeUIDownloadsHost)
256 return &NewWebUI<DownloadsUI>; 258 return &NewWebUI<DownloadsUI>;
257 if (url.host() == chrome::kChromeUIDialogHost) 259 if (url.host() == chrome::kChromeUIDialogHost)
258 return &NewWebUI<ConstrainedWebDialogUI>; 260 return &NewWebUI<ConstrainedWebDialogUI>;
259 // Feedback on Android uses the built-in feedback app. 261 // Feedback on Android uses the built-in feedback app.
260 if (url.host() == chrome::kChromeUIFeedbackHost) 262 if (url.host() == chrome::kChromeUIFeedbackHost)
261 return &NewWebUI<FeedbackUI>; 263 return &NewWebUI<FeedbackUI>;
262 // chrome://flags is currently unsupported on Android.
263 // TODO(satish): Enable after http://crbug.com/143146 is fixed.
264 if (url.host() == chrome::kChromeUIFlagsHost)
265 return &NewWebUI<FlagsUI>;
266 // Flash is not available on android. 264 // Flash is not available on android.
267 if (url.host() == chrome::kChromeUIFlashHost) 265 if (url.host() == chrome::kChromeUIFlashHost)
268 return &NewWebUI<FlashUI>; 266 return &NewWebUI<FlashUI>;
269 // Help is implemented with native UI elements on Android. 267 // Help is implemented with native UI elements on Android.
270 if (url.host() == chrome::kChromeUIHelpFrameHost) 268 if (url.host() == chrome::kChromeUIHelpFrameHost)
271 return &NewWebUI<HelpUI>; 269 return &NewWebUI<HelpUI>;
272 // chrome://inspect isn't supported on Android. Page debugging is handled by a 270 // chrome://inspect isn't supported on Android. Page debugging is handled by a
273 // remote devtools on the host machine, and other elements (Shared Workers, 271 // remote devtools on the host machine, and other elements (Shared Workers,
274 // extensions, etc) aren't supported. 272 // extensions, etc) aren't supported.
275 if (url.host() == chrome::kChromeUIInspectHost) 273 if (url.host() == chrome::kChromeUIInspectHost)
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 return NULL; 588 return NULL;
591 589
592 #if defined(OS_WIN) 590 #if defined(OS_WIN)
593 if (page_url.host() == chrome::kChromeUIConflictsHost) 591 if (page_url.host() == chrome::kChromeUIConflictsHost)
594 return ConflictsUI::GetFaviconResourceBytes(scale_factor); 592 return ConflictsUI::GetFaviconResourceBytes(scale_factor);
595 #endif 593 #endif
596 594
597 if (page_url.host() == chrome::kChromeUICrashesHost) 595 if (page_url.host() == chrome::kChromeUICrashesHost)
598 return CrashesUI::GetFaviconResourceBytes(scale_factor); 596 return CrashesUI::GetFaviconResourceBytes(scale_factor);
599 597
598 if (page_url.host() == chrome::kChromeUIFlagsHost)
599 return FlagsUI::GetFaviconResourceBytes(scale_factor);
600
600 if (page_url.host() == chrome::kChromeUIHistoryHost) 601 if (page_url.host() == chrome::kChromeUIHistoryHost)
601 return HistoryUI::GetFaviconResourceBytes(scale_factor); 602 return HistoryUI::GetFaviconResourceBytes(scale_factor);
602 603
603 #if !defined(OS_ANDROID) 604 #if !defined(OS_ANDROID)
604 // Flash is not available on android. 605 // Flash is not available on android.
605 if (page_url.host() == chrome::kChromeUIFlashHost) 606 if (page_url.host() == chrome::kChromeUIFlashHost)
606 return FlashUI::GetFaviconResourceBytes(scale_factor); 607 return FlashUI::GetFaviconResourceBytes(scale_factor);
607 608
608 // Android uses the native download manager. 609 // Android uses the native download manager.
609 if (page_url.host() == chrome::kChromeUIDownloadsHost) 610 if (page_url.host() == chrome::kChromeUIDownloadsHost)
610 return DownloadsUI::GetFaviconResourceBytes(scale_factor); 611 return DownloadsUI::GetFaviconResourceBytes(scale_factor);
611 612
612 // chrome://flags is currently unsupported on Android.
613 // TODO(satish): Enable after http://crbug.com/143146 is fixed.
614 if (page_url.host() == chrome::kChromeUIFlagsHost)
615 return FlagsUI::GetFaviconResourceBytes(scale_factor);
616
617 // Android doesn't use the Options pages. 613 // Android doesn't use the Options pages.
618 if (page_url.host() == chrome::kChromeUISettingsFrameHost) 614 if (page_url.host() == chrome::kChromeUISettingsFrameHost)
619 return options::OptionsUI::GetFaviconResourceBytes(scale_factor); 615 return options::OptionsUI::GetFaviconResourceBytes(scale_factor);
620 616
621 // Android doesn't use the plugins pages. 617 // Android doesn't use the plugins pages.
622 if (page_url.host() == chrome::kChromeUIPluginsHost) 618 if (page_url.host() == chrome::kChromeUIPluginsHost)
623 return PluginsUI::GetFaviconResourceBytes(scale_factor); 619 return PluginsUI::GetFaviconResourceBytes(scale_factor);
624 #endif 620 #endif
625 621
626 return NULL; 622 return NULL;
627 } 623 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698