Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: chrome/renderer/extensions/resource_request_policy.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/resource_request_policy.cc
diff --git a/chrome/renderer/extensions/resource_request_policy.cc b/chrome/renderer/extensions/resource_request_policy.cc
index d6ac03a3a77300c62ca62f5d61e12dfebc3eb7d5..f69008e97df1df7c6c64cf31320e346a0fee9326 100644
--- a/chrome/renderer/extensions/resource_request_policy.cc
+++ b/chrome/renderer/extensions/resource_request_policy.cc
@@ -8,6 +8,7 @@
#include "base/logging.h"
#include "base/stringprintf.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/url_parser/url_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/common/url_constants.h"
@@ -68,7 +69,8 @@ bool ResourceRequestPolicy::CanRequestResource(
// - devtools (chrome-extension:// URLs are loaded into frames of devtools
// to support the devtools extension APIs)
bool is_dev_tools = page_url.SchemeIs(chrome::kChromeDevToolsScheme) &&
- !extension->devtools_url().is_empty();
+ !extensions::URLInfo::url(
+ extension, extensions::URLInfo::DEVTOOLS_PAGE).is_empty();
bool transition_allowed =
!content::PageTransitionIsWebTriggerable(transition_type);
// - unreachable web page error page (to allow showing the icon of the

Powered by Google App Engine
This is Rietveld 408576698