chrome/common/extensions/permissions/permission_set.cc - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permission_set.cc

diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc

index 81f5ce4196a0692ebf668e9cb4e33d2ad3b7bc41..3ba430dc2fefc92be0f0947c4d3d1add7f00cdef 100644

--- a/chrome/common/extensions/permissions/permission_set.cc

+++ b/chrome/common/extensions/permissions/permission_set.cc

@@ -8,6 +8,7 @@

#include <iterator>

#include <string>

+#include "chrome/common/extensions/api/url_parser/url_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/permissions/permissions_info.h"

#include "content/public/common/url_constants.h"

@@ -529,8 +530,8 @@ void PermissionSet::InitImplicitExtensionPermissions(

// Add the implied permissions.

if (!extension->plugins().empty())

apis_.insert(APIPermission::kPlugin);

- if (!extension->devtools_url().is_empty())

+ if (!extensions::URLInfo::url(

Yoyo Zhou 2012/12/27 17:16:17 This is in the extensions namespace.

Joe Thomas 2012/12/30 04:26:00 Done.

+ extension, extensions::URLInfo::DEVTOOLS_PAGE).is_empty())

apis_.insert(APIPermission::kDevtools);

// Add the scriptable hosts.