Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/common/extensions/extension.h

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index d2fd4500e3f52b0d3e1056aa47cba40cb72b589e..d97a04f646804d164af40d7d201c3380755ae787 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -561,11 +561,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Whether context menu should be shown for page and browser actions.
bool ShowConfigureContextMenus() const;
- // Returns the Homepage URL for this extension. If homepage_url was not
- // specified in the manifest, this returns the Google Gallery URL. For
- // third-party extensions, this returns a blank GURL.
- GURL GetHomepageURL() const;
-
// Returns a list of paths (relative to the extension dir) for images that
// the browser might load (like themes and page action icons).
std::set<FilePath> GetBrowserImages() const;
@@ -749,7 +744,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return has_background_page() && !background_page_is_persistent_;
}
const GURL& options_url() const { return options_url_; }
- const GURL& devtools_url() const { return devtools_url_; }
const GURL& details_url() const { return details_url_;}
const PermissionSet* optional_permission_set() const {
return optional_permission_set_.get();
@@ -911,7 +905,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
string16* error);
bool LoadDescription(string16* error);
bool LoadManifestVersion(string16* error);
- bool LoadHomepageURL(string16* error);
bool LoadUpdateURL(string16* error);
bool LoadIcons(string16* error);
bool LoadCommands(string16* error);
@@ -949,7 +942,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadExtensionFeatures(APIPermissionSet* api_permissions,
string16* error);
bool LoadManifestHandlerFeatures(string16* error);
- bool LoadDevToolsPage(string16* error);
bool LoadInputComponents(const APIPermissionSet& api_permissions,
string16* error);
bool LoadContentScripts(string16* error);
@@ -1172,9 +1164,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Optional URL to a page for setting options/preferences.
GURL options_url_;
- // Optional URL to a devtools extension page.
- GURL devtools_url_;
-
// URL to the webstore page of the extension.
GURL details_url_;
@@ -1193,10 +1182,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// A map of display properties.
scoped_ptr<base::DictionaryValue> theme_display_properties_;
- // The homepage for this extension. Useful if it is not hosted by Google and
- // therefore does not have a Gallery URL.
- GURL homepage_url_;
-
// URL for fetching an update manifest
GURL update_url_;

Powered by Google App Engine
This is Rietveld 408576698