chrome/chrome_tests_unit.gypi - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/url_parser/url_parser_api_factory.h ('K') | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/api/url_parser/devtools_page_handler.h » ('j') | chrome/common/extensions/api/url_parser/devtools_page_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_tests_unit.gypi

diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi

index 73b5ef847ff46a08667d2ba6a2dabbea002010fa..ed3d6163ae55e074c3cf8928312436e253678d53 100644

--- a/chrome/chrome_tests_unit.gypi

+++ b/chrome/chrome_tests_unit.gypi

@@ -1445,6 +1445,8 @@

'common/content_settings_helper_unittest.cc',

'common/content_settings_pattern_parser_unittest.cc',

'common/content_settings_pattern_unittest.cc',

+ 'common/extensions/api/url_parser/devtools_page_manifests_unittest.cc',

Yoyo Zhou 2012/12/27 17:16:17 I don't think these tests need to move.

Joe Thomas 2012/12/30 04:26:00 Done. Moved back to its original place.

Yoyo Zhou 2013/01/03 01:45:54 They still seem to be deleted in the latest patchs

Joe Thomas 2013/01/03 19:56:31 It was showing with "D" symbol but side-by-side di

Yoyo Zhou 2013/01/03 22:55:32 Ok, that's weird. I filed a bug about this. https:

+ 'common/extensions/api/url_parser/homepage_url_manifests_unittest.cc',

'common/extensions/command_unittest.cc',

'common/extensions/csp_validator_unittest.cc',

'common/extensions/event_filter_unittest.cc',

@@ -1469,11 +1471,9 @@

'common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_default_unittest.cc',

- 'common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_excludematches_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_filebrowser_unittest.cc',

- 'common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_icon_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc',

'common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc',