Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2730)

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_model.cc
diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc
index ce6b6e8823ee8ef5dcfd3275e43d77eb8b8d1947..ff50afebfbbcddb6cccf5680962227e01af3f1b0 100644
--- a/chrome/browser/extensions/extension_context_menu_model.cc
+++ b/chrome/browser/extensions/extension_context_menu_model.cc
@@ -16,6 +16,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/common/extensions/api/url_parser/url_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/pref_names.h"
@@ -73,7 +74,8 @@ bool ExtensionContextMenuModel::IsCommandIdEnabled(int command_id) const {
} else if (command_id == NAME) {
// The NAME links to the Homepage URL. If the extension doesn't have a
// homepage, we just disable this menu item.
- return extension->GetHomepageURL().is_valid();
+ return extensions::URLInfo::url(
+ extension, extensions::URLInfo::HOMEPAGE_URL).is_valid();
} else if (command_id == INSPECT_POPUP) {
WebContents* web_contents = chrome::GetActiveWebContents(browser_);
if (!web_contents)
@@ -101,9 +103,10 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
switch (command_id) {
case NAME: {
- OpenURLParams params(extension->GetHomepageURL(), Referrer(),
- NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK,
- false);
+ OpenURLParams params(
+ extensions::URLInfo::url(
+ extension, extensions::URLInfo::HOMEPAGE_URL), Referrer(),
+ NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_LINK, false);
browser_->OpenURL(params);
break;
}

Powered by Google App Engine
This is Rietveld 408576698