chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | chrome/browser/extensions/api/url_parser/url_parser_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 873278153e323e224e1dbb4bcc1a34744ab1ea5c..a8078e1b62038e6bf401657da94ca19604728306 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"

#include "chrome/browser/view_type_utils.h"

#include "chrome/common/extensions/api/developer_private.h"

+#include "chrome/common/extensions/api/url_parser/url_info.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

@@ -98,7 +99,8 @@ scoped_ptr<developer::ItemInfo> DeveloperPrivateAPI::CreateItemInfo(

NULL);

info->icon = icon.spec();

- info->homepage_url.reset(new std::string(item.GetHomepageURL().spec()));

+ info->homepage_url.reset(new std::string(extensions::URLInfo::url(

+ &item, extensions::URLInfo::HOMEPAGE_URL).spec()));

if (!item.options_url().is_empty()) {

info->options_url.reset(new std::string(item.options_url().spec()));

}