Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10497)

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch-rebased- 2 Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest_url_handler.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/permissions/permission_set.cc
diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc
index 81f5ce4196a0692ebf668e9cb4e33d2ad3b7bc41..df2b8b1b91ecba206c697adfd6aeee2eda9bc212 100644
--- a/chrome/common/extensions/permissions/permission_set.cc
+++ b/chrome/common/extensions/permissions/permission_set.cc
@@ -9,6 +9,7 @@
#include <string>
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/common/extensions/permissions/permissions_info.h"
#include "content/public/common/url_constants.h"
#include "extensions/common/url_pattern.h"
@@ -529,8 +530,7 @@ void PermissionSet::InitImplicitExtensionPermissions(
// Add the implied permissions.
if (!extension->plugins().empty())
apis_.insert(APIPermission::kPlugin);
-
- if (!extension->devtools_url().is_empty())
+ if (!ManifestURL::GetDevToolsPage(extension).is_empty())
apis_.insert(APIPermission::kDevtools);
// Add the scriptable hosts.
« no previous file with comments | « chrome/common/extensions/manifest_url_handler.cc ('k') | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698