chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc - Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/devtools/devtools_page_handler.cc ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

deleted file mode 100644

index 4ee81e7a2d307d5059fe6c58f2c05bdfa0910012..0000000000000000000000000000000000000000

--- a/chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc

+++ /dev/null

@@ -1,22 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

-#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

-#include "testing/gtest/include/gtest/gtest.h"

-namespace errors = extension_manifest_errors;

-TEST_F(ExtensionManifestTest, DevToolsExtensions) {

- LoadAndExpectError("devtools_extension_url_invalid_type.json",

- errors::kInvalidDevToolsPage);

- scoped_refptr<extensions::Extension> extension;

- extension = LoadAndExpectSuccess("devtools_extension.json");

- EXPECT_EQ(extension->url().spec() + "devtools.html",

- extension->devtools_url().spec());

- EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());