Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4140)

Unified Diff: chrome/common/extensions/extension.h

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index d2fd4500e3f52b0d3e1056aa47cba40cb72b589e..7b42d1a68dd796da515288230617a817481549f7 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -749,7 +749,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return has_background_page() && !background_page_is_persistent_;
}
const GURL& options_url() const { return options_url_; }
- const GURL& devtools_url() const { return devtools_url_; }
const GURL& details_url() const { return details_url_;}
const PermissionSet* optional_permission_set() const {
return optional_permission_set_.get();
@@ -949,7 +948,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadExtensionFeatures(APIPermissionSet* api_permissions,
string16* error);
bool LoadManifestHandlerFeatures(string16* error);
- bool LoadDevToolsPage(string16* error);
bool LoadInputComponents(const APIPermissionSet& api_permissions,
string16* error);
bool LoadContentScripts(string16* error);
@@ -1172,9 +1170,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Optional URL to a page for setting options/preferences.
GURL options_url_;
- // Optional URL to a devtools extension page.
- GURL devtools_url_;
-
// URL to the webstore page of the extension.
GURL details_url_;

Powered by Google App Engine
This is Rietveld 408576698