Move the parsing of homepage_url" and "devtools_page" out of Extension.

chrome/common/extensions/api/url_parser/url_info.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_API_URL_PARSER_URL_INFO_H_
+#define CHROME_COMMON_EXTENSIONS_API_URL_PARSER_URL_INFO_H_
+
+#include <string>
+
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_handler.h"
+
+namespace extensions {
+
+struct URLInfo : public Extension::ManifestData {
+  enum URLType {

[Yoyo Zhou, 2012/12/27 17:16:17]

I don't think this interface makes sense. Why not
GetDevToolsPage(extension)
GetHomepageURL(extension)
?

[Joe Thomas, 2012/12/30 04:26:00]

Done.

+    DEVTOOLS_PAGE,
+    HOMEPAGE_URL
+  };
+
+  // URL parsed from the extension manifest file.
+  GURL url_;
+
+  static const GURL url(const Extension* extension, const URLType type);

[Yoyo Zhou, 2012/12/27 17:16:17]

This should be of type const GURL& to avoid making a copy.

[Joe Thomas, 2012/12/30 04:26:00]

Since we create a temporary GURL object inside GetHomepageURL(extension)
function, a reference cannot be returned for GetHomepageURL.

[Yoyo Zhou, 2013/01/03 01:45:54]

This was my point about GURL::EmptyGURL - you can avoid a temporary.

[Joe Thomas, 2013/01/03 19:56:31]

If you look at ManifestURL::GetHomepageURL definition, apart from creating the
EmptyURL, we need to create one more temporary GURL object with
"extension_urls::GetWebstoreItemDetailURLPrefix() + extension->id()". Because of
that we will not be able to return reference in that one getter function.

[Yoyo Zhou, 2013/01/03 22:55:32]

Oh, okay. This will be the same as the old GetHomepageURL then, so that's fine.

+};
+
+}  // namespace extensions
+
+#endif  // CHROME_COMMON_EXTENSIONS_API_URL_PARSER_URL_INFO_H_