Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/common/extensions/api/url_parser/devtools_page_manifests_unittest.cc

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/api/url_parser/devtools_page_handler.h"
6 #include "chrome/common/extensions/api/url_parser/url_info.h"
7 #include "chrome/common/extensions/extension.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest_handler.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace keys = extension_manifest_keys;
14 namespace errors = extension_manifest_errors;
15
16 using extensions::Extension;
17
18 namespace {
19
20 class DevToolsPageManifestTest : public ExtensionManifestTest {
21 virtual void SetUp() OVERRIDE {
22 ExtensionManifestTest::SetUp();
23 extensions::ManifestHandler::Register(keys::kDevToolsPage,
24 new extensions::DevToolsPageHandler);
25 }
26 };
27
28 TEST_F(DevToolsPageManifestTest, DevToolsExtensions) {
29 LoadAndExpectError("devtools_extension_url_invalid_type.json",
30 errors::kInvalidDevToolsPage);
31
32 scoped_refptr<extensions::Extension> extension;
33 extension = LoadAndExpectSuccess("devtools_extension.json");
34 EXPECT_EQ(extension->url().spec() + "devtools.html", extensions::URLInfo::url(
35 extension, extensions::URLInfo::DEVTOOLS_PAGE).spec());
36 EXPECT_TRUE(extension->HasEffectiveAccessToAllHosts());
37 }
38
39 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698