Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/common/extensions/extension.h

Issue 11624036: Move the parsing of homepage_url" and "devtools_page" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <iosfwd> 9 #include <iosfwd>
10 #include <map> 10 #include <map>
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 const std::vector<std::string>& background_scripts() const { 742 const std::vector<std::string>& background_scripts() const {
743 return background_scripts_; 743 return background_scripts_;
744 } 744 }
745 bool has_persistent_background_page() const { 745 bool has_persistent_background_page() const {
746 return has_background_page() && background_page_is_persistent_; 746 return has_background_page() && background_page_is_persistent_;
747 } 747 }
748 bool has_lazy_background_page() const { 748 bool has_lazy_background_page() const {
749 return has_background_page() && !background_page_is_persistent_; 749 return has_background_page() && !background_page_is_persistent_;
750 } 750 }
751 const GURL& options_url() const { return options_url_; } 751 const GURL& options_url() const { return options_url_; }
752 const GURL& devtools_url() const { return devtools_url_; }
753 const GURL& details_url() const { return details_url_;} 752 const GURL& details_url() const { return details_url_;}
754 const PermissionSet* optional_permission_set() const { 753 const PermissionSet* optional_permission_set() const {
755 return optional_permission_set_.get(); 754 return optional_permission_set_.get();
756 } 755 }
757 const PermissionSet* required_permission_set() const { 756 const PermissionSet* required_permission_set() const {
758 return required_permission_set_.get(); 757 return required_permission_set_.get();
759 } 758 }
760 // Appends |new_warnings| to install_warnings(). 759 // Appends |new_warnings| to install_warnings().
761 void AddInstallWarnings(const InstallWarningVector& new_warnings); 760 void AddInstallWarnings(const InstallWarningVector& new_warnings);
762 const InstallWarningVector& install_warnings() const { 761 const InstallWarningVector& install_warnings() const {
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 const base::DictionaryValue& intent_service, 941 const base::DictionaryValue& intent_service,
943 string16* error); 942 string16* error);
944 bool LoadWebIntentServices(string16* error); 943 bool LoadWebIntentServices(string16* error);
945 bool LoadFileHandler(const std::string& handler_id, 944 bool LoadFileHandler(const std::string& handler_id,
946 const base::DictionaryValue& handler_info, 945 const base::DictionaryValue& handler_info,
947 string16* error); 946 string16* error);
948 bool LoadFileHandlers(string16* error); 947 bool LoadFileHandlers(string16* error);
949 bool LoadExtensionFeatures(APIPermissionSet* api_permissions, 948 bool LoadExtensionFeatures(APIPermissionSet* api_permissions,
950 string16* error); 949 string16* error);
951 bool LoadManifestHandlerFeatures(string16* error); 950 bool LoadManifestHandlerFeatures(string16* error);
952 bool LoadDevToolsPage(string16* error);
953 bool LoadInputComponents(const APIPermissionSet& api_permissions, 951 bool LoadInputComponents(const APIPermissionSet& api_permissions,
954 string16* error); 952 string16* error);
955 bool LoadContentScripts(string16* error); 953 bool LoadContentScripts(string16* error);
956 bool LoadPageAction(string16* error); 954 bool LoadPageAction(string16* error);
957 bool LoadBrowserAction(string16* error); 955 bool LoadBrowserAction(string16* error);
958 bool LoadScriptBadge(string16* error); 956 bool LoadScriptBadge(string16* error);
959 bool LoadSystemIndicator(APIPermissionSet* api_permissions, string16* error); 957 bool LoadSystemIndicator(APIPermissionSet* api_permissions, string16* error);
960 bool LoadFileBrowserHandlers(string16* error); 958 bool LoadFileBrowserHandlers(string16* error);
961 // Helper method to load a FileBrowserHandlerList from the manifest. 959 // Helper method to load a FileBrowserHandlerList from the manifest.
962 FileBrowserHandlerList* LoadFileBrowserHandlersHelper( 960 FileBrowserHandlerList* LoadFileBrowserHandlersHelper(
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1165 1163
1166 // True if the background page can be scripted by pages of the app or 1164 // True if the background page can be scripted by pages of the app or
1167 // extension, in which case all such pages must run in the same process. 1165 // extension, in which case all such pages must run in the same process.
1168 // False if such pages are not permitted to script the background page, 1166 // False if such pages are not permitted to script the background page,
1169 // allowing them to run in different processes. 1167 // allowing them to run in different processes.
1170 bool allow_background_js_access_; 1168 bool allow_background_js_access_;
1171 1169
1172 // Optional URL to a page for setting options/preferences. 1170 // Optional URL to a page for setting options/preferences.
1173 GURL options_url_; 1171 GURL options_url_;
1174 1172
1175 // Optional URL to a devtools extension page.
1176 GURL devtools_url_;
1177
1178 // URL to the webstore page of the extension. 1173 // URL to the webstore page of the extension.
1179 GURL details_url_; 1174 GURL details_url_;
1180 1175
1181 // The public key used to sign the contents of the crx package. 1176 // The public key used to sign the contents of the crx package.
1182 std::string public_key_; 1177 std::string public_key_;
1183 1178
1184 // A map of resource id's to relative file paths. 1179 // A map of resource id's to relative file paths.
1185 scoped_ptr<base::DictionaryValue> theme_images_; 1180 scoped_ptr<base::DictionaryValue> theme_images_;
1186 1181
1187 // A map of color names to colors. 1182 // A map of color names to colors.
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
1329 1324
1330 UpdatedExtensionPermissionsInfo( 1325 UpdatedExtensionPermissionsInfo(
1331 const Extension* extension, 1326 const Extension* extension,
1332 const PermissionSet* permissions, 1327 const PermissionSet* permissions,
1333 Reason reason); 1328 Reason reason);
1334 }; 1329 };
1335 1330
1336 } // namespace extensions 1331 } // namespace extensions
1337 1332
1338 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 1333 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698