Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 11624023: Fix flakyness in PrefMemberTest::MoveToThread (Closed)

Created:
8 years ago by qsr
Modified:
8 years ago
Reviewers:
battre
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix flakyness in PrefMemberTest::MoveToThread In MoveToThread, a thread object is owned by a ref-counted object that is passed around thread. It means the thread object can be deleted on a thread that is not the one that created it, which will trigger a DCHECK. This CL ensures that the second thread is always stopped on the main thread. R=battre@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/prefs/public/pref_member_unittest.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qsr
8 years ago (2012-12-21 10:11:48 UTC) #1
battre
lgtm
8 years ago (2012-12-21 10:23:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/11624023/1
8 years ago (2012-12-21 10:31:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-21 13:14:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/11624023/1
8 years ago (2012-12-21 13:15:22 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-21 14:08:06 UTC) #6
Message was sent while issue was closed.
Change committed as 174390

Powered by Google App Engine
This is Rietveld 408576698