components/tracing/DEPS - Issue 11624021: Move tracing component to src/components

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/tracing/DEPS

Issue 11624021: Move tracing component to src/components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge LKGR Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "+ipc",	3 "+ipc",

	4 "+components/tracing",
	jam 2012/12/27 21:44:25 I don't think this is needed because by default a I don't think this is needed because by default a directory is allowed to include other files in it? kaiwang 2012/12/27 22:08:31 Done. Show quoted text On 2012/12/27 21:44:25, John Abd-El-Malek wrote: > I don't think this is needed because by default a directory is allowed to > include other files in it? Done.
4	5

5 # This component will be compiled into NaCl, so it shouldn't depend on	6 # This component will be compiled into NaCl, so it shouldn't depend on

6 # anything else in content.	7 # anything in content.

7 "-content",	8 "-content",
	jam 2012/12/27 21:44:25 you can remove this comment and rule now you can remove this comment and rule now kaiwang 2012/12/27 22:08:31 Done. Show quoted text On 2012/12/27 21:44:25, John Abd-El-Malek wrote: > you can remove this comment and rule now Done. jam 2012/12/27 22:44:15 actually, nvm.i just realized that components/DEPS Show quoted text On 2012/12/27 22:08:31, kaiwang wrote: > On 2012/12/27 21:44:25, John Abd-El-Malek wrote: > > you can remove this comment and rule now > > Done. actually, nvm.i just realized that components/DEPS has +content/public in it, so this comment and rule are needed (fine to do this in a followup if you wish). kaiwang 2012/12/27 22:57:27 OK, will add it back OK, will add it back
8 "+content/components/tracing",

9 ]	9 ]

OLD	NEW

« no previous file with comments | « components/components_tracing_untrusted.gyp ('k') | components/tracing/OWNERS » ('j') | no next file with comments »