Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make dtor protected Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.cc
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc
index 1bd857543ca82bc60eeef524e771bd4620b027b9..b9b2a10e9c63613f2217e2d5e01bc83b7366b16c 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc
@@ -19,6 +19,10 @@ ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
}
ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
+ OnDestroy();
Fady Samuel 2015/06/05 17:31:13 This is still bad. Don't call this here.
lazyboy 2015/06/05 21:24:00 Bad patch upload. Done.
+}
+
+void ExtensionsGuestViewContainer::OnDestroy() {
// Call the destruction callback, if one is registered.
if (!destruction_callback_.IsEmpty()) {
v8::HandleScope handle_scope(destruction_isolate_);
@@ -32,6 +36,8 @@ ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
blink::WebScopedMicrotaskSuppression suppression;
callback->Call(context->Global(), 0 /* argc */, nullptr);
+
+ destruction_callback_.Reset();
}
}

Powered by Google App Engine
This is Rietveld 408576698