extensions/renderer/guest_view/extensions_guest_view_container.h - Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 1162053003: Move BrowserPluginDelegate's lifetime mgmt out of content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up for review. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/browser_plugin/browser_plugin.cc ('K') | « content/renderer/render_frame_impl.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('j') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/extensions_guest_view_container.h

diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.h b/extensions/renderer/guest_view/extensions_guest_view_container.h

index 4e3f3e9e5ec4c25f689afec81610b60f7bf4c7c7..d05bd9570ea3bebb29c0748620781fbdd37ae27d 100644

--- a/extensions/renderer/guest_view/extensions_guest_view_container.h

+++ b/extensions/renderer/guest_view/extensions_guest_view_container.h

@@ -32,6 +32,8 @@ class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer {

private:

void CallElementResizeCallback(const gfx::Size& new_size);

+ void OnDestroy() override;

v8::Global<v8::Function> destruction_callback_;

v8::Isolate* destruction_isolate_;