Move BrowserPluginDelegate's lifetime mgmt out of content/

content/renderer/browser_plugin/browser_plugin_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_
 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_
 
 #include "base/id_map.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/renderer/render_process_observer.h"
@@ skipping 16 matching lines @@
  public:
   static BrowserPluginManager* Get();
 
   BrowserPluginManager();
   ~BrowserPluginManager() override;
 
   // Creates a new BrowserPlugin object.
   // BrowserPlugin is responsible for associating itself with the
   // BrowserPluginManager via AddBrowserPlugin. When it is destroyed, it is
   // responsible for removing its association via RemoveBrowserPlugin.
-  BrowserPlugin* CreateBrowserPlugin(
-      RenderFrame* render_frame,
-      scoped_ptr<BrowserPluginDelegate> delegate);
+  // The |delegate| is expected to manage its own lifetime.
+  // Generally BrowserPlugin calls DidDestroyElement() on the delegate and
+  // right now the delegate destroys itself once it hears that callback.
+  BrowserPlugin* CreateBrowserPlugin(RenderFrame* render_frame,
+                                     BrowserPluginDelegate* delegate);
 
   void Attach(int browser_plugin_instance_id);
 
   void Detach(int browser_plugin_instance_id);
 
   void AddBrowserPlugin(int browser_plugin_instance_id,
                         BrowserPlugin* browser_plugin);
   void RemoveBrowserPlugin(int browser_plugin_instance_id);
   BrowserPlugin* GetBrowserPlugin(int browser_plugin_instance_id) const;
 
@@ skipping 15 matching lines @@
 
   // This map is keyed by guest instance IDs.
   IDMap<BrowserPlugin> instances_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPluginManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_