Issue 11620011: Issue 11428116 had to be reverted as it broke build due to a unused variable.

Issue 11620011: Issue 11428116 had to be reverted as it broke build due to a unused variable. (Closed)

Created:
8 years ago by Gaurav

Modified:
8 years ago

Reviewers:
NOT Mike Tsao (try miket), miket_OOO, sky, estrade

CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Issue 11428116 had to be reverted as it broke build due to a unused variable. This CL is the copy of the issue, fixing the problem. First few API implementation of AppsDebuggerPrivate. This CL adds the skeleton for AppsDebuggerPrivate APIs with Implementation of getItemInfo, Inspect and AutoUpdate. Will be adding apitest to the CL. BUG=149036 TBR=estrade@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11428116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173612 0039d316-1c4b-4281-b951-d872f2087c98 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173811

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed formatting #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+824 lines, -1 line)			Patch
A	chrome/browser/extensions/api/developer_private/developer_private_api.h	View		1 chunk	+128 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/developer_private/developer_private_api.cc	View	1	1 chunk	+294 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/developer_private/developer_private_api_factory.h	View		1 chunk	+39 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/developer_private/developer_private_api_factory.cc	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/developer_private/developer_private_apitest.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/apps_debugger/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/api.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/extensions/api/developer_private.idl	View		1 chunk	+91 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/manifest.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/hosted_app/manifest.json	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/packaged_app/main.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/packaged_app/main.js	View		1 chunk	+12 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/packaged_app/manifest.json	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/simple_extension/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/simple_extension/pages/options.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/test/basics.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/test/basics.js	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/test/common.js	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/developer/test/manifest.json	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Gaurav

@miket: CL 11428116 had to reverted as it broke clang build due to unused variable. ...

8 years ago (2012-12-18 04:41:22 UTC) #1

Gaurav

https://chromiumcodereview.appspot.com/11620011/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://chromiumcodereview.appspot.com/11620011/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode183 chrome/browser/extensions/api/developer_private/developer_private_api.cc:183: switch (type) { In the previous CL we had ...

8 years ago (2012-12-18 18:11:01 UTC) #2

miket_OOO

Rubber-stamp LGTM, but please fix one formatting issue. https://chromiumcodereview.appspot.com/11620011/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://chromiumcodereview.appspot.com/11620011/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode188 chrome/browser/extensions/api/developer_private/developer_private_api.cc:188: = ...

8 years ago (2012-12-18 18:45:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/11620011/5001

8 years ago (2012-12-18 19:56:58 UTC) #4

Message was sent while issue was closed.

Change committed as 173811

Expand Messages | Collapse Messages