Removed READ_ONLY constants from IDBTransaction class

sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of indexed_db;
 
 /// @domName $DOMNAME
 class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
 
   Transaction transaction(storeName_OR_storeNames, String mode) {
     if (mode != 'readonly' && mode != 'readwrite') {
       throw new ArgumentError(mode);
     }
 
     // TODO(sra): Ensure storeName_OR_storeNames is a string or List<String>,
     // and copy to JavaScript array if necessary.
 
     if (_transaction_fn != null) {

[sra1, 2012/12/18 00:56:52]

remove

[Emily Fortuna, 2012/12/18 18:57:47]

Done.

       return _transaction_fn(this, storeName_OR_storeNames, mode);
     }
 
     // Try and create a transaction with a string mode.  Browsers that expect a
     // numeric mode tend to convert the string into a number.  This fails
     // silently, resulting in zero ('readonly').
     var txn = _transaction(storeName_OR_storeNames, mode);
-    if (_hasNumericMode(txn)) {
-      _transaction_fn = _transaction_numeric_mode;
-      txn = _transaction_fn(this, storeName_OR_storeNames, mode);
-    } else {
-      _transaction_fn = _transaction_string_mode;
-    }
+    _transaction_fn = _transaction_string_mode;

[sra1, 2012/12/18 00:56:52]

Since this is the only remaining version of the function, we can get rid of the
variable _transaction_fn and call _transaction directly.

[Emily Fortuna, 2012/12/18 18:57:47]

Done.

     return txn;
   }
 
   static Transaction _transaction_string_mode($CLASSNAME db, stores, mode) {

[sra1, 2012/12/18 00:56:52]

remove

[Emily Fortuna, 2012/12/18 18:57:47]

Done.

     return db._transaction(stores, mode);
   }
 
-  static Transaction _transaction_numeric_mode($CLASSNAME db, stores, mode) {
-    int intMode;
-    if (mode == 'readonly') intMode = Transaction.READ_ONLY;
-    if (mode == 'readwrite') intMode = Transaction.READ_WRITE;
-    return db._transaction(stores, intMode);
-  }
-
   @JSName('transaction')
   Transaction _transaction(stores, mode) native;
 
   static bool _hasNumericMode(txn) =>

[sra1, 2012/12/18 00:56:52]

remove

[Emily Fortuna, 2012/12/18 18:57:47]

Done.

       JS('bool', 'typeof(#.mode) === "number"', txn);
 
 $!MEMBERS}
 
 // TODO(sra): This should be a static member of IDBTransaction but dart2js
 // can't handle that.  Move it back after dart2js is completely done.
 var _transaction_fn;  // Assigned one of the static methods.

[sra1, 2012/12/18 00:56:52]

remove

[Emily Fortuna, 2012/12/18 18:57:47]

Done.