Pull InputIme stuff out of ExtensionService

Pull InputIme stuff out of ExtensionService

Make InputImeAPI a PKS.

Patch from Joe Thomas <mhx348@motorola.com>;.

BUG=159265
TBR=ben@chromium.org for gyp


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173950

[Yoyo Zhou, 2012-12-18 22:39:16]

LGTM

https://chromiumcodereview.appspot.com/11618005/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/input_ime/input_ime_api.h (right):

https://chromiumcodereview.appspot.com/11618005/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/input_ime/input_ime_api.h:181: virtual void
Shutdown() OVERRIDE;
You don't need this if it does nothing.

https://chromiumcodereview.appspot.com/11618005/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/input_ime/input_ime_api.h:183:
InputImeEventRouter* input_ime_event_router();
Doesn't need to be public.

[Joe Thomas, 2012-12-18 22:53:03]

Thanks for the review.

https://codereview.chromium.org/11618005/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/input_ime/input_ime_api.h (right):

https://codereview.chromium.org/11618005/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/input_ime/input_ime_api.h:181: virtual void
Shutdown() OVERRIDE;
On 2012/12/18 22:39:16, Yoyo Zhou wrote:
> You don't need this if it does nothing.

Done.

https://codereview.chromium.org/11618005/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/input_ime/input_ime_api.h:183:
InputImeEventRouter* input_ime_event_router();
On 2012/12/18 22:39:16, Yoyo Zhou wrote:
> Doesn't need to be public.

Done.

[Joe Thomas, 2012-12-18 22:53:49]

+ben for gyp
+mirandac for profiles/

[Miranda Callahan, 2012-12-18 23:21:05]

On 2012/12/18 22:53:49, Joe Thomas wrote:
> +ben for gyp
> +mirandac for profiles/

profile_dependency_manager.cc LGTM

[commit-bot: I haz the power, 2012-12-18 23:28:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11618005/5001

[commit-bot: I haz the power, 2012-12-19 02:12:36]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for dinner.
Please email commit-bot@chromium.org with the CL url.

[commit-bot: I haz the power, 2012-12-19 02:16:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11618005/5001

[commit-bot: I haz the power, 2012-12-19 05:36:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_aura&n...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-12-19 05:43:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11618005/5001

[commit-bot: I haz the power, 2012-12-19 10:35:33]

Retried try job too often on win_aura for step(s) content_browsertests

[commit-bot: I haz the power, 2012-12-19 12:00:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11618005/5001

[commit-bot: I haz the power, 2012-12-19 18:16:22]

Change committed as 173950