chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 11615011: Small modifications to safebrowsing code to make it simpler to add the extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: seriously there is a macro called check() in AssertMacros.h wow Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 2326c91dff634cbeefee779d33ca92884762530e..3a4f2a564a9df554a39e27db4cceeb1401cef6ed 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -17,6 +17,7 @@

#include "chrome/browser/safe_browsing/malware_details.h"

#include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

+#include "chrome/browser/safe_browsing/safe_browsing_util.h"

#include "chrome/browser/safe_browsing/ui_manager.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_tabstrip.h"

@@ -68,11 +69,13 @@ class FakeSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {

}

void OnCheckBrowseURLDone(const GURL& gurl, Client* client) {

- SafeBrowsingDatabaseManager::SafeBrowsingCheck check;

- check.urls.push_back(gurl);

- check.client = client;

- check.threat_type = badurls[gurl.spec()];

- client->OnSafeBrowsingResult(check);

+ SafeBrowsingDatabaseManager::SafeBrowsingCheck sb_check(

+ std::vector<GURL>(1, gurl),

+ std::vector<SBFullHash>(),

+ client,

+ safe_browsing_util::MALWARE);

+ sb_check.url_results[0] = badurls[gurl.spec()];

+ client->OnSafeBrowsingResult(sb_check);

}

void SetURLThreatType(const GURL& url, SBThreatType threat_type) {