Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11614023: [Android] Fix specification of android build deps. (Closed)

Created:
8 years ago by Yaron
Modified:
8 years ago
Reviewers:
cjhopman, Isaac (away)
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Fix specification of android build deps. Our dependencies are managed in gyp and not ant so we don't need ant to resolve dependant libraries. This fixes the spurious output of: [subant] No sub-builds to iterate on for each test apk. BUG=164395 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174065

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : more general #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/ant/common.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
8 years ago (2012-12-18 05:16:24 UTC) #1
Yaron
Turns out this applies to all ant targets and not just apk tests. Looking at ...
8 years ago (2012-12-18 05:23:43 UTC) #2
Isaac (away)
lgtm
8 years ago (2012-12-18 05:39:49 UTC) #3
cjhopman
lgtm
8 years ago (2012-12-20 01:07:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11614023/3
8 years ago (2012-12-20 01:08:16 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-20 01:09:29 UTC) #6
Message was sent while issue was closed.
Change committed as 174065

Powered by Google App Engine
This is Rietveld 408576698