Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: gpu/command_buffer/service/common_decoder.cc

Issue 11613021: Removing the JumpRelative, Call, CallRelative and Return commands. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use Noops instead of Jump; Remove Jump command. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/common_decoder.cc
diff --git a/gpu/command_buffer/service/common_decoder.cc b/gpu/command_buffer/service/common_decoder.cc
index 5a73cbd66b81ef78624724b7f75ee710f4a7e0ce..fa97c1c2730084658740a9586a65f995ae467203 100644
--- a/gpu/command_buffer/service/common_decoder.cc
+++ b/gpu/command_buffer/service/common_decoder.cc
@@ -186,56 +186,6 @@ error::Error CommonDecoder::HandleSetToken(
return error::kNoError;
}
-error::Error CommonDecoder::HandleJump(
- uint32 immediate_data_size,
- const cmd::Jump& args) {
- if (!engine_->SetGetOffset(args.offset)) {
- return error::kInvalidArguments;
- }
- return error::kNoError;
-}
-
-error::Error CommonDecoder::HandleJumpRelative(
- uint32 immediate_data_size,
- const cmd::JumpRelative& args) {
- if (!engine_->SetGetOffset(engine_->GetGetOffset() + args.offset)) {
- return error::kInvalidArguments;
- }
- return error::kNoError;
-}
-
-error::Error CommonDecoder::HandleCall(
- uint32 immediate_data_size,
- const cmd::Call& args) {
- if (!PushAddress(args.offset)) {
- return error::kInvalidArguments;
- }
- return error::kNoError;
-}
-
-error::Error CommonDecoder::HandleCallRelative(
- uint32 immediate_data_size,
- const cmd::CallRelative& args) {
- if (!PushAddress(engine_->GetGetOffset() + args.offset)) {
- return error::kInvalidArguments;
- }
- return error::kNoError;
-}
-
-error::Error CommonDecoder::HandleReturn(
- uint32 immediate_data_size,
- const cmd::Return& args) {
- if (call_stack_.empty()) {
- return error::kInvalidArguments;
- }
- CommandAddress return_address = call_stack_.top();
- call_stack_.pop();
- if (!engine_->SetGetOffset(return_address.offset)) {
- return error::kInvalidArguments;
- }
- return error::kNoError;
-}
-
error::Error CommonDecoder::HandleSetBucketSize(
uint32 immediate_data_size,
const cmd::SetBucketSize& args) {
« no previous file with comments | « gpu/command_buffer/common/cmd_buffer_common.h ('k') | gpu/command_buffer/service/common_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698