build/android/pylib/android_commands.py - Issue 11613014: Assert that md5sum was built instead of failing silently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 11613014: Assert that md5sum was built instead of failing silently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 66f705f4ca378aeb4063c2adbacb2275f483a291..e73e1a92dca1f878e028af3d57f3ad3c8d3d375d 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -618,9 +618,7 @@ class AndroidCommands(object):

default_build_type)

if not os.path.exists(md5sum_path):

md5sum_path = '%s/Release/md5sum_bin' % cmd_helper.OutDirectory.get()

- if not os.path.exists(md5sum_path):

- print >> sys.stderr, 'Please build md5sum.'

- sys.exit(1)

+ assert os.path.exists(md5sum_path), 'Please build md5sum.'

command = 'push %s %s' % (md5sum_path, MD5SUM_DEVICE_PATH)

assert _HasAdbPushSucceeded(self._adb.SendCommand(command))

self._md5sum_path = md5sum_path

« no previous file with comments | « no previous file | no next file » | no next file with comments »