Issue 11612022: Re-apply "What if you closurize identical?" but this time don't be magic: it requires the compiler …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11612022: Re-apply "What if you closurize identical?" but this time don't be magic: it requires the compiler … (Closed)

Created:
8 years ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Re-apply "What if you closurize identical?" but this time don't be magic: it requires the compiler to recognize the identical call in multiple places (e.g. tryInlineMethod) and I'd rather have the logic code in the library. Committed: https://code.google.com/p/dart/source/detail?r=16789

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -45 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/core_patch.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	tests/language/identical_closure2_test.dart	View	1	2 chunks	+2 lines, -28 lines	0 comments	Download
M	tests/language/identical_closure_test.dart	View	1	3 chunks	+4 lines, -12 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Thanks Kasper. PTAL, I have updated the test file to not depend on existing issues.

7 years, 11 months ago (2013-01-08 11:14:20 UTC) #3

ngeoffray

7 years, 11 months ago (2013-01-08 12:30:33 UTC) #5

I forgot that we have both JS undefined and JS null to cover Dart null. I
updated the implementation of identical to deal with it.

Expand Messages | Collapse Messages