Linux sandbox: modify GYP files to compile under Android.

Linux sandbox: compile partially under Android.

Get a subset of sandbox/linux to compile under Android.

BUG=166704
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173954

[jln (very slow on Chromium), 2012-12-18 22:39:02]

Markus, do you mind reviewing this ?

It gets a subset of sandbox/linux to compile on Android. Not everything is
there.

Most notably, I had to inline part of linux/audit.h in the same way that we had
to do for prctl.h and seccomp.h

[palmer, 2012-12-18 22:54:55]

https://chromiumcodereview.appspot.com/11612014/diff/11001/sandbox/sandbox.gyp
File sandbox/sandbox.gyp (right):

https://chromiumcodereview.appspot.com/11612014/diff/11001/sandbox/sandbox.gy...
sandbox/sandbox.gyp:21: # A 'default' to accomodate the "sandbox" target/
Should be ".", not "/". :)

[jln (very slow on Chromium), 2012-12-18 22:57:42]

Also switched to using target_defaults as recommended by Mark.

https://chromiumcodereview.appspot.com/11612014/diff/11001/sandbox/sandbox.gyp
File sandbox/sandbox.gyp (right):

https://chromiumcodereview.appspot.com/11612014/diff/11001/sandbox/sandbox.gy...
sandbox/sandbox.gyp:21: # A 'default' to accomodate the "sandbox" target/
On 2012/12/18 22:54:55, Chris P. wrote:
> Should be ".", not "/". :) 

Done.

[Markus (顧孟勤), 2012-12-18 23:20:48]

lgtm

Just minor comments about cleaning up some white-space as best as you can. Other
than that, this looks fine. Thanks.

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
File sandbox/linux/seccomp-bpf/sandbox_bpf.h (right):

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
sandbox/linux/seccomp-bpf/sandbox_bpf.h:11: //#include <linux/audit.h>
Probably insert a space so it looks the same as for <linux/seccomp.h>

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
sandbox/linux/seccomp-bpf/sandbox_bpf.h:60: // For audit.h
This is all generally fine, and I don't have a problem with adding definitions
that are missing in our toolchain.

But it would be nice if we could reformat things a little bit to try to align
the defined values vertically. We already do this a little bit with the existing
definitions in this file.

You probably won't be able to do this perfectly, but a best effort would already
make things a little more readable.

[jln (very slow on Chromium), 2012-12-18 23:24:55]

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
File sandbox/linux/seccomp-bpf/sandbox_bpf.h (right):

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
sandbox/linux/seccomp-bpf/sandbox_bpf.h:11: //#include <linux/audit.h>
On 2012/12/18 23:20:48, Markus (顧孟勤) wrote:
> Probably insert a space so it looks the same as for <linux/seccomp.h>

Done.

https://chromiumcodereview.appspot.com/11612014/diff/13007/sandbox/linux/secc...
sandbox/linux/seccomp-bpf/sandbox_bpf.h:60: // For audit.h
On 2012/12/18 23:20:48, Markus (顧孟勤) wrote:
> This is all generally fine, and I don't have a problem with adding definitions
> that are missing in our toolchain.
> 
> But it would be nice if we could reformat things a little bit to try to align
> the defined values vertically. We already do this a little bit with the
existing
> definitions in this file.
> 
> You probably won't be able to do this perfectly, but a best effort would
already
> make things a little more readable.

Done.

[commit-bot: I haz the power, 2012-12-19 01:04:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/11612014/4002

[commit-bot: I haz the power, 2012-12-19 08:17:57]

Retried try job too often on win_aura for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-19 18:19:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/11612014/4002

[commit-bot: I haz the power, 2012-12-19 18:26:19]

Change committed as 173954