Add support for specifying my_activity.py list format.

Add support for specifying my_activity.py list format.

This adds the possibility to specify the format for your activity
through: -f <format>, --output-format=<format>

<format> is specified as in strings.format(...).

It is also possible to specify the output format for specific
activity types.

This enables users to use other formats such as Markdown:
[%(title)s](%(url)s)

This CL also adds support for new variables such as author,
and adds a generic framework for adding more variables.

BUG=166519
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=174203

[nyquist, 2012-12-17 23:00:09]

cjhopman: PTAL

[cjhopman, 2012-12-17 23:03:51]

https://codereview.chromium.org/11607007/diff/1/my_activity.py
File my_activity.py (left):

https://codereview.chromium.org/11607007/diff/1/my_activity.py#oldcode713
my_activity.py:713: print '%s %s' % (
Could this use string.format() instead of %?

[cjhopman, 2012-12-17 23:08:27]

https://codereview.chromium.org/11607007/diff/1/my_activity.py
File my_activity.py (right):

https://codereview.chromium.org/11607007/diff/1/my_activity.py#newcode719
my_activity.py:719: def print_issue(issue, output_format):
To ensure that the different formatters are always called with dicts with the
same set of keys, maybe have each of these functions call another with the
arguments that the formatters expect.

https://codereview.chromium.org/11607007/diff/1/my_activity.py#newcode870
my_activity.py:870: ' %(url)s %(title)s')
Should the help also specify what named arguments are available to the format
string?

[nyquist, 2012-12-19 07:08:11]

PTAL.
* Addressed comments
* Added support for author
* Added generic framework for optional variables
* Fixed bug in parsing owner for google code issues

https://codereview.chromium.org/11607007/diff/1/my_activity.py
File my_activity.py (left):

https://codereview.chromium.org/11607007/diff/1/my_activity.py#oldcode713
my_activity.py:713: print '%s %s' % (
On 2012/12/17 23:03:51, cjhopman wrote:
> Could this use string.format() instead of %?

Done.

https://codereview.chromium.org/11607007/diff/1/my_activity.py
File my_activity.py (right):

https://codereview.chromium.org/11607007/diff/1/my_activity.py#newcode719
my_activity.py:719: def print_issue(issue, output_format):
On 2012/12/17 23:08:27, cjhopman wrote:
> To ensure that the different formatters are always called with dicts with the
> same set of keys, maybe have each of these functions call another with the
> arguments that the formatters expect.

Done.

https://codereview.chromium.org/11607007/diff/1/my_activity.py#newcode870
my_activity.py:870: ' %(url)s %(title)s')
On 2012/12/17 23:08:27, cjhopman wrote:
> Should the help also specify what named arguments are available to the format
> string?

Done.

[cjhopman, 2012-12-20 17:29:38]

https://codereview.chromium.org/11607007/diff/6001/my_activity.py
File my_activity.py (right):

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode914
my_activity.py:914: 'By default, all activity will be printed on the '
s/printed on/printed in/

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode924
my_activity.py:924: '-f', '--output_format',
Please don't use _ in options.

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode925
my_activity.py:925: dest='output_format', metavar='<format>',
You don't need to specify dest= for any of these as it will default to what you
specified.

[nyquist, 2012-12-20 17:54:24]

PTAL

[cjhopman, 2012-12-20 17:59:00]

lgtm

[nyquist, 2012-12-20 18:01:09]

cmp@: PTAL for owners rubberstamp.

[nyquist, 2012-12-20 18:01:56]

https://codereview.chromium.org/11607007/diff/6001/my_activity.py
File my_activity.py (right):

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode914
my_activity.py:914: 'By default, all activity will be printed on the '
On 2012/12/20 17:29:38, cjhopman wrote:
> s/printed on/printed in/

Done.

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode924
my_activity.py:924: '-f', '--output_format',
On 2012/12/20 17:29:38, cjhopman wrote:
> Please don't use _ in options.

Done.

https://codereview.chromium.org/11607007/diff/6001/my_activity.py#newcode925
my_activity.py:925: dest='output_format', metavar='<format>',
On 2012/12/20 17:29:38, cjhopman wrote:
> You don't need to specify dest= for any of these as it will default to what
you
> specified.

Done.

[cmp, 2012-12-20 18:44:54]

lgtm

[commit-bot: I haz the power, 2012-12-20 19:23:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/11607007/11002

[commit-bot: I haz the power, 2012-12-20 19:26:51]

Change committed as 174203