Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11606010: Reduce verbosity of Android builds. (Closed)

Created:
8 years ago by Yaron
Modified:
8 years ago
Reviewers:
cjhopman, Isaac (away)
CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Reduce verbosity of Android builds. There's a lot of boilerplate from running ant. Passing '-q' silences most of it. BUG=164395 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173688

Patch Set 1 #

Total comments: 2

Patch Set 2 : -quiet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M build/android/ant/chromium-jars.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/ant/sdk-targets.xml View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/prepare_library_for_apk View 1 chunk +1 line, -1 line 0 comments Download
M build/apk_test.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/java.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/android/generate_native_test.py View 6 chunks +7 lines, -7 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test_apk.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Yaron
8 years ago (2012-12-17 21:51:14 UTC) #1
Isaac (away)
lgtm, but let's wait for Chris
8 years ago (2012-12-17 21:54:28 UTC) #2
Yaron
On 2012/12/17 21:51:14, Yaron wrote: There's still a bunch of output but it's less verboe: ...
8 years ago (2012-12-17 21:59:30 UTC) #3
cjhopman
lgtm with nit https://codereview.chromium.org/11606010/diff/1/build/apk_test.gypi File build/apk_test.gypi (right): https://codereview.chromium.org/11606010/diff/1/build/apk_test.gypi#newcode51 build/apk_test.gypi:51: '-q', Nit: can this be --quiet ...
8 years ago (2012-12-17 22:53:08 UTC) #4
Yaron
https://codereview.chromium.org/11606010/diff/1/build/apk_test.gypi File build/apk_test.gypi (right): https://codereview.chromium.org/11606010/diff/1/build/apk_test.gypi#newcode51 build/apk_test.gypi:51: '-q', On 2012/12/17 22:53:08, cjhopman wrote: > Nit: can ...
8 years ago (2012-12-17 23:01:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11606010/6002
8 years ago (2012-12-17 23:25:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11606010/6002
8 years ago (2012-12-18 01:16:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11606010/6002
8 years ago (2012-12-18 02:04:33 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years ago (2012-12-18 07:16:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/11606010/6002
8 years ago (2012-12-18 07:49:32 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-18 07:54:37 UTC) #11
Message was sent while issue was closed.
Change committed as 173688

Powered by Google App Engine
This is Rietveld 408576698