Emit classes using ASTs

Emit more stuff via ASTs

- Block CodeBuffer.toString() to prevent accidental loss of  sourcemap info.
- keep compiled code as ASTs rather than CodeBuffers.
- class members are collected in a ClassBuilder and emitted as a js.ObjectInitializer.
- Use double quotes for JS strings more uniformly.

Unminified code is 5% larger due to corrected indentation.
This does not affect minified code.

Committed: https://code.google.com/p/dart/source/detail?r=16646

[floitsch, 2013-01-04 10:31:03]

LGTM.

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/code_buffer.dart (right):

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/code_buffer.dart:70: throw "Don't use
CodeBuffer.toString() since it drops sourcemap data.";
make this an internal error.

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js/printer.dart (right):

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js/printer.dart:34: void newLine() {
do we really need this?
If yes, please add comments, so that the editor can provide hover-over
information, explaining the difference between newLine and lineOut.

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js/printer.dart:783: newLine();
why "newLine" and not "lineOut" ?

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:39: void
addProperty(String name, js.Expression value) {
Since this is a class-builder, I would call this "addMember".

https://codereview.chromium.org/11602016/diff/12013/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:923:
arguments.add(js.string(namer.operatorIs(type.element)));
maybe add an "assert" that the result of 'namer.operatorIs' != 'v' ?

[sra1, 2013-01-04 23:47:52]

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/code_buffer.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/code_buffer.dart:70: throw "Don't use
CodeBuffer.toString() since it drops sourcemap data.";
On 2013/01/04 10:31:03, floitsch wrote:
> make this an internal error.

I will tackle this in a separate CL.

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/js/printer.dart:34: void newLine() {
On 2013/01/04 10:31:03, floitsch wrote:
> do we really need this?
> If yes, please add comments, so that the editor can provide hover-over
> information, explaining the difference between newLine and lineOut.

Done.

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/js/printer.dart:783: newLine();
On 2013/01/04 10:31:03, floitsch wrote:
> why "newLine" and not "lineOut" ?

To force newlines even under --minify.
We can play with this, but it matches current behaviour.
Otherwise the code is completely unreadable when minified.

[floitsch, 2013-01-04 23:58:20]

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/12013/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/js/printer.dart:783: newLine();
On 2013/01/04 23:47:52, sra1 wrote:
> On 2013/01/04 10:31:03, floitsch wrote:
> > why "newLine" and not "lineOut" ?
> 
> To force newlines even under --minify.
> We can play with this, but it matches current behaviour.
> Otherwise the code is completely unreadable when minified.

Fine with me, but I wouldn't consider readability a necessary feature for
minified code.

[ngeoffray, 2013-01-10 10:40:07]

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/compiler.dart:54: js.Expression code =
world.universe.generatedCode[element];
Did you measure the memory impact of this change?

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/js/printer.dart:684: if (field ==
'"super"') return false;
Using super breaks android AFAIR. Why did you need to change this?

[sra1, 2013-01-10 16:32:42]

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/compiler.dart:54: js.Expression code =
world.universe.generatedCode[element];
On 2013/01/10 10:40:07, ngeoffray wrote:
> Did you measure the memory impact of this change?

Is there a convenient way to do this?

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
File sdk/lib/_internal/compiler/implementation/js/printer.dart (right):

https://chromiumcodereview.appspot.com/11602016/diff/19001/sdk/lib/_internal/...
sdk/lib/_internal/compiler/implementation/js/printer.dart:684: if (field ==
'"super"') return false;
On 2013/01/10 10:40:07, ngeoffray wrote:
> Using super breaks android AFAIR. Why did you need to change this?

Without this line, we get
  super: "X",
with the line, we get
  "super": "X",

It was not a problem before because super was simply printed in quotes.