Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 11600002: Add cros wrapper to depot_tools. (Closed)

Created:
8 years ago by davidjames
Modified:
8 years ago
Reviewers:
Peter Mayo, rcui, sosa
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add cros wrapper to depot_tools. The cros wrapper in depot_tools is a centralized wrapper for all cros commands. Adding this to depot_tools allows developers to run the 'cros' tool from anywhere inside a Chrome OS checkout. BUG=none TEST=Verify the cros wrapper works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=173491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + cros View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
davidjames
PTAL
8 years ago (2012-12-16 05:32:05 UTC) #1
sosa
lgtm
8 years ago (2012-12-16 07:29:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidjames@chromium.org/11600002/1
8 years ago (2012-12-16 16:53:47 UTC) #3
commit-bot: I haz the power
Presubmit check for 11600002-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-16 16:55:56 UTC) #4
Peter Mayo
lgtm
8 years ago (2012-12-17 18:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidjames@chromium.org/11600002/1
8 years ago (2012-12-17 18:17:10 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-17 18:20:03 UTC) #7
Message was sent while issue was closed.
Change committed as 173491

Powered by Google App Engine
This is Rietveld 408576698