src/messages.js - Issue 11598011: Make sure error message formatting does not have side effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 11598011: Make sure error message formatting does not have side effects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.js

diff --git a/src/messages.js b/src/messages.js

index 2cb778fc13c1fbc7b2e7991acda618f9389430ac..0bfaf6c6118f636e45a029d0e5dabc4ec02c3ae5 100644

--- a/src/messages.js

+++ b/src/messages.js

@@ -192,7 +192,7 @@ function NoSideEffectToString(obj) {

if (IS_NULL(obj)) return 'null';

if (IS_FUNCTION(obj)) return %_CallFunction(obj, FunctionToString);

if (IS_OBJECT(obj) && %GetDataProperty(obj, "toString") === ObjectToString) {

- var constructor = obj.constructor;

+ var constructor = %GetDataProperty(obj, "constructor");

if (typeof constructor == "function") {

var constructorName = constructor.name;

if (IS_STRING(constructorName) && constructorName !== "") {

« no previous file with comments | « no previous file | test/mjsunit/error-tostring.js » ('j') | no next file with comments »