Add dependency on Android tools to native unittests APKs targets

Add dependency on Android tools to native unittests APKs targets

This patch adds dependencies on Android tools (port forwarder and md5 util used
for conditional file pushes) required to run native unittests APKs to the APKs
targets. 

BUG=161257
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173728

[ppi, 2012-12-17 15:24:48]

Small change - what do you guys think?

[Philippe, 2012-12-17 15:41:10]

Thanks Przemek, lgtm with minor nits!

Marcus is on vacation, I'm adding Yaron.

https://codereview.chromium.org/11597008/diff/1/build/apk_test.gypi
File build/apk_test.gypi (right):

https://codereview.chromium.org/11597008/diff/1/build/apk_test.gypi#newcode24
build/apk_test.gypi:24:
'<(DEPTH)/tools/android/android_tools.gyp:native_unittests_android_utils',
Nit: I would simply call the target 'android_tools'. You can add 'fake_dns'
there I believe too.

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.gyp
File tools/android/android_tools.gyp (right):

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.g...
tools/android/android_tools.gyp:14: 'forwarder2/forwarder.gyp:forwarder2',
Nit: alpha sort.

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.g...
tools/android/android_tools.gyp:15: ]
Nit: we tend to end such lines with ','.

[ppi, 2012-12-17 16:06:13]

Thanks for the review, Philippe! I have addressed your remarks in patch set 2.

https://codereview.chromium.org/11597008/diff/1/build/apk_test.gypi
File build/apk_test.gypi (right):

https://codereview.chromium.org/11597008/diff/1/build/apk_test.gypi#newcode24
build/apk_test.gypi:24:
'<(DEPTH)/tools/android/android_tools.gyp:native_unittests_android_utils',
On 2012/12/17 15:41:10, Philippe wrote:
> Nit: I would simply call the target 'android_tools'. You can add 'fake_dns'
> there I believe too.

Sure - I renamed the target and added fake_dns in patch set 2.

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.gyp
File tools/android/android_tools.gyp (right):

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.g...
tools/android/android_tools.gyp:14: 'forwarder2/forwarder.gyp:forwarder2',
On 2012/12/17 15:41:10, Philippe wrote:
> Nit: alpha sort.

Thanks, fixed in patch set 2.

https://codereview.chromium.org/11597008/diff/1/tools/android/android_tools.g...
tools/android/android_tools.gyp:15: ]
On 2012/12/17 15:41:10, Philippe wrote:
> Nit: we tend to end such lines with ','.

Thanks, fixed in patch set 2.

[Yaron, 2012-12-17 18:47:20]

lgtm

Please also update build/all_android.gyp to depend on this new target instead of
each individual target.

[digit1, 2012-12-18 09:25:59]

lgtm

That's great :). Like Yaron, I'd recommend modifying build/all_android.gyp

[ppi, 2012-12-18 09:59:07]

Thanks Yaron and David! I have updated all_android.gyp in patch set 3.

[commit-bot: I haz the power, 2012-12-18 12:03:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ppi@chromium.org/11597008/11001

[commit-bot: I haz the power, 2012-12-18 14:15:31]

Change committed as 173728

[jonnialva90, 2016-05-25 18:46:28]

jonnialva90@gmail.com changed reviewers:
+ jonnialva90@gmail.com