Precisely measure duration of mark and sweep phases. Changed print_cumulative_gc_stat flag to only …

src/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 543 matching lines @@
         return cell_space();
       case CODE_SPACE:
         return code_space();
       case NEW_SPACE:
       case LO_SPACE:
         UNREACHABLE();
     }
     return NULL;
   }
 
+  // TODO(hpayer): remove, should be handled by GCTracer

[Michael Starzinger, 2013/01/29 12:13:47]

Move all of these accessors down to where the others are declared.

[Hannes Payer (out of office), 2013/01/30 10:42:20]

Done.

+  void AddMarkingTime(double marking_time) {
+    marking_time_ += marking_time;
+  }
+
+  double marking_time() const {
+    return marking_time_;
+  }
+
+  // TODO(hpayer): remove, should be handled by GCTracer
+  void AddSweepingTime(double sweeping_time) {
+    sweeping_time_ += sweeping_time;
+  }
+
+  double sweeping_time() const {
+    return sweeping_time_;
+  }
+
   bool always_allocate() { return always_allocate_scope_depth_ != 0; }
   Address always_allocate_scope_depth_address() {
     return reinterpret_cast<Address>(&always_allocate_scope_depth_);
   }
   bool linear_allocation() {
     return linear_allocation_scope_depth_ != 0;
   }
 
   Address* NewSpaceAllocationTopAddress() {
     return new_space_.allocation_top_address();
@@ skipping 996 matching lines @@
   }
 
   // Returns maximum GC pause.
   int get_max_gc_pause() { return max_gc_pause_; }
 
   // Returns maximum size of objects alive after GC.
   intptr_t get_max_alive_after_gc() { return max_alive_after_gc_; }
 
   // Returns minimal interval between two subsequent collections.
   int get_min_in_mutator() { return min_in_mutator_; }
 

[Michael Starzinger, 2013/01/29 12:13:47]

... to here.

[Hannes Payer (out of office), 2013/01/30 10:42:20]

Done.

   MarkCompactCollector* mark_compact_collector() {
     return &mark_compact_collector_;
   }
 
   StoreBuffer* store_buffer() {
     return &store_buffer_;
   }
 
   Marking* marking() {
     return &marking_;
@@ skipping 424 matching lines @@
   inline void InitializeFunction(
       JSFunction* function,
       SharedFunctionInfo* shared,
       Object* prototype);
 
   // Total RegExp code ever generated
   double total_regexp_code_generated_;
 
   GCTracer* tracer_;
 
-
   // Allocates a small number to string cache.
   MUST_USE_RESULT MaybeObject* AllocateInitialNumberStringCache();
   // Creates and installs the full-sized number string cache.
   void AllocateFullSizeNumberStringCache();
   // Get the length of the number to string cache based on the max semispace
   // size.
   int FullSizeNumberStringCacheLength();
   // Flush the number to string cache.
   void FlushNumberStringCache();
 
@@ skipping 117 matching lines @@
   intptr_t max_alive_after_gc_;
 
   // Minimal interval between two subsequent collections.
   int min_in_mutator_;
 
   // Size of objects alive after last GC.
   intptr_t alive_after_last_gc_;
 
   double last_gc_end_timestamp_;
 
+  // GC time spent in marking

[Michael Starzinger, 2013/01/29 12:13:47]

s/GC time/Cumulative GC time/

[Hannes Payer (out of office), 2013/01/30 10:42:20]

Done.

+  double marking_time_;
+
+  // GC time spent in sweeping

[Michael Starzinger, 2013/01/29 12:13:47]

Likewise.

[Hannes Payer (out of office), 2013/01/30 10:42:20]

Done.

+  double sweeping_time_;
+
   MarkCompactCollector mark_compact_collector_;
 
   StoreBuffer store_buffer_;
 
   Marking marking_;
 
   IncrementalMarking incremental_marking_;
 
   int number_idle_notifications_;
   unsigned int last_idle_notification_gc_count_;
@@ skipping 706 matching lines @@
   AssertNoAllocation no_alloc;  // i.e. no gc allowed.
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
 };
 #endif  // DEBUG || LIVE_OBJECT_LIST
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_H_