Precisely measure duration of mark and sweep phases. Changed print_cumulative_gc_stat flag to only …

src/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 543 matching lines @@
         return cell_space();
       case CODE_SPACE:
         return code_space();
       case NEW_SPACE:
       case LO_SPACE:
         UNREACHABLE();
     }
     return NULL;
   }
 
+  void AddMarkingTime(double marking_time) {

[Michael Starzinger, 2013/01/28 13:55:39]

Drop these callbacks.

[Hannes Payer (out of office), 2013/01/29 12:01:54]

As discussed offline, I will mark them TODO remove.

On 2013/01/28 13:55:39, Michael Starzinger wrote:

+    marking_time_ += marking_time;
+  }
+
+  double marking_time() const {
+    return marking_time_;
+  }
+
+  void AddSweepingTime(double sweeping_time) {
+    sweeping_time_ += sweeping_time;
+  }
+
+  double sweeping_time() const {
+    return sweeping_time_;
+  }
+
   bool always_allocate() { return always_allocate_scope_depth_ != 0; }
   Address always_allocate_scope_depth_address() {
     return reinterpret_cast<Address>(&always_allocate_scope_depth_);
   }
   bool linear_allocation() {
     return linear_allocation_scope_depth_ != 0;
   }
 
   Address* NewSpaceAllocationTopAddress() {
     return new_space_.allocation_top_address();
@@ skipping 1441 matching lines @@
   inline void InitializeFunction(
       JSFunction* function,
       SharedFunctionInfo* shared,
       Object* prototype);
 
   // Total RegExp code ever generated
   double total_regexp_code_generated_;
 
   GCTracer* tracer_;
 
+  double marking_time_;

[Michael Starzinger, 2013/01/28 13:55:39]

Move these counters into IncrementalMarking and the GCTracer respectively.

[Hannes Payer (out of office), 2013/01/29 12:01:54]

As discussed offline, they stay in heap.h

On 2013/01/28 13:55:39, Michael Starzinger wrote:

+  double sweeping_time_;
 
   // Allocates a small number to string cache.
   MUST_USE_RESULT MaybeObject* AllocateInitialNumberStringCache();
   // Creates and installs the full-sized number string cache.
   void AllocateFullSizeNumberStringCache();
   // Get the length of the number to string cache based on the max semispace
   // size.
   int FullSizeNumberStringCacheLength();
   // Flush the number to string cache.
   void FlushNumberStringCache();
@@ skipping 844 matching lines @@
   AssertNoAllocation no_alloc;  // i.e. no gc allowed.
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
 };
 #endif  // DEBUG || LIVE_OBJECT_LIST
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_H_