MessagePumpAuraX11: Make root_window_dispatchers_ an ObserverList.

MessagePumpAuraX11: Make root_window_dispatchers_ an ObserverList.

Using std::vector caused crashes in cases where a Dispatch call resulted in a Dispatcher being added and that addition provoked reallocation of the vector's storage.  This resulted in a bad iterator dereference in the dispatch loop.

BUG=chrome-os-partner:15544
TEST=Monitor unplugging/power removal still works.  The crash case no longer crashes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175452

[oshima, 2012-12-18 20:38:32]

lgtm with nit

https://codereview.chromium.org/11593015/diff/1/base/message_pump_aurax11.h
File base/message_pump_aurax11.h (right):

https://codereview.chromium.org/11593015/diff/1/base/message_pump_aurax11.h#n...
base/message_pump_aurax11.h:108: ObserverList<MessagePumpDispatcher>
root_window_dispatchers_;
Please add comment why we're using ObserverList for non observers.

[sabercrombie1, 2012-12-18 23:39:39]

My understanding is that I can't use trybots, not being a committer.  Could a
reviewer with this access try this commit?

[commit-bot: I haz the power, 2012-12-19 00:00:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sabercrombie@chromium.org/11593015/6001

[commit-bot: I haz the power, 2012-12-19 00:00:09]

Presubmit check for 11593015-6001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[willchan no longer on Chromium, 2012-12-19 17:25:42]

https://codereview.chromium.org/11593015/diff/6001/base/message_pump_aurax11.h
File base/message_pump_aurax11.h (right):

https://codereview.chromium.org/11593015/diff/6001/base/message_pump_aurax11....
base/message_pump_aurax11.h:16: #include <vector>
Can you get rid of this now?

https://codereview.chromium.org/11593015/diff/6001/base/message_pump_aurax11....
base/message_pump_aurax11.h:112: ObserverList<MessagePumpDispatcher>
root_window_dispatchers_;
YOu need the #include for this.

[sabercrombie1, 2012-12-20 17:47:32]

Could you take another look please?

[sabercrombie1, 2012-12-21 20:59:15]

Anyone?

[willchan no longer on Chromium, 2012-12-21 22:11:05]

lgtm

[commit-bot: I haz the power, 2012-12-21 22:19:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sabercrombie@chromium.org/11593015/14002

[commit-bot: I haz the power, 2012-12-22 02:23:05]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-07 18:35:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sabercrombie@chromium.org/11593015/14002

[commit-bot: I haz the power, 2013-01-07 20:56:19]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 23:31:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sabercrombie@chromium.org/11593015/14002

[commit-bot: I haz the power, 2013-01-08 01:28:05]

Change committed as 175452