Issue 11590015: [Android WebView] Fix FindBugs warnings in AwSettingsTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11590015: [Android WebView] Fix FindBugs warnings in AwSettingsTest (Closed)

Created:
8 years ago by mnaganov (inactive)

Modified:
8 years ago

Reviewers:
joth, benm (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Fix FindBugs warnings in AwSettingsTest R=benm@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173465

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -25 lines)			Patch
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java	View		12 chunks	+18 lines, -20 lines	0 comments	Download
	M	build/android/findbugs_filter/findbugs_known_bugs.txt	View		5 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/11590015/1

8 years ago (2012-12-17 13:56:27 UTC) #3

joth

8 years ago (2012-12-17 17:58:47 UTC) #5

Thanks for fixing those Mikhail.



On 17 December 2012 07:12, <commit-bot@chromium.org> wrote:

> Change committed as 173465
>
>
https://chromiumcodereview.**appspot.com/11590015/<https://chromiumcodereview...
>
> --
>
>
>

Expand Messages | Collapse Messages