Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: chrome/common/extensions/api/extension_action/script_badge_handler.cc

Issue 11588004: Move ScriptBadge, ActionInfo out of Extension; preparation for BrowserAction (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h"
6
7 #include "base/memory/scoped_ptr.h"
8 #include "base/utf_string_conversions.h"
9 #include "base/values.h"
10 #include "chrome/common/extensions/api/extension_action/action_handler_helpers.h "
11 #include "chrome/common/extensions/extension.h"
12 #include "chrome/common/extensions/extension_constants.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/common/extensions/feature_switch.h"
15
16 namespace errors = extension_manifest_errors;
17
18 namespace extensions {
19
20 // static
21 const ActionInfo* ScriptBadgeInfo::GetScriptBadge(
22 const Extension* extension) {
23 ScriptBadgeInfo* info = static_cast<ScriptBadgeInfo*>(
24 extension->GetManifestData(extension_manifest_keys::kScriptBadge));
25 return info ? info->script_badge_info.get() : NULL;
26 }
27
28 ScriptBadgeHandler::ScriptBadgeHandler() {
29 }
30
31 ScriptBadgeHandler::~ScriptBadgeHandler() {
32 }
33
34 bool ScriptBadgeHandler::Parse(const base::Value* value,
35 Extension* extension,
36 string16* error) {
37 scoped_ptr<ScriptBadgeInfo> info(new ScriptBadgeInfo);
38
39 // So as to not confuse developers if they specify a script badge section
40 // in the manifest, show a warning if the script badge declaration isn't
41 // going to have any effect.
42 if (!FeatureSwitch::script_badges()->IsEnabled()) {
43 extension->AddInstallWarning(
44 Extension::InstallWarning(Extension::InstallWarning::FORMAT_TEXT,
45 errors::kScriptBadgeRequiresFlag));
46 }
47
48 const DictionaryValue* dict = NULL;
49 if (!value->GetAsDictionary(&dict)) {
50 *error = ASCIIToUTF16(extension_manifest_errors::kInvalidScriptBadge);
51 return false;
52 }
53
54 info->script_badge_info =
55 LoadActionInfo(extension, dict, error);
56
57 if (!info->script_badge_info.get())
58 return false; // Failed to parse script badge definition.
59
60 // Script badges always use their extension's title and icon so users can rely
61 // on the visual appearance to know which extension is running. This isn't
62 // bulletproof since an malicious extension could use a different 16x16 icon
63 // that matches the icon of a trusted extension, and users wouldn't be warned
64 // during installation.
65
66 if (!info->script_badge_info->default_title.empty()) {
67 extension->AddInstallWarning(
68 Extension::InstallWarning(Extension::InstallWarning::FORMAT_TEXT,
69 errors::kScriptBadgeTitleIgnored));
70 }
71 info->script_badge_info->default_title = extension->name();
72
73 if (!info->script_badge_info->default_icon.empty()) {
74 extension->AddInstallWarning(
75 Extension::InstallWarning(Extension::InstallWarning::FORMAT_TEXT,
76 errors::kScriptBadgeIconIgnored));
77 }
78
79 info->script_badge_info->default_icon.Clear();
80 for (size_t i = 0; i < extension_misc::kNumScriptBadgeIconSizes; ++i) {
81 std::string path = extension->icons().Get(
82 extension_misc::kScriptBadgeIconSizes[i],
83 ExtensionIconSet::MATCH_BIGGER);
84 if (!path.empty()) {
85 info->script_badge_info->default_icon.Add(
86 extension_misc::kScriptBadgeIconSizes[i], path);
87 }
88 }
89
90 extension->SetManifestData(extension_manifest_keys::kScriptBadge,
91 info.release());
92 return true;
93 }
94
95 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698